Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Move timeout_ms option to compile function #63

Closed
Khatskevich opened this issue Mar 2, 2018 · 0 comments
Closed

Move timeout_ms option to compile function #63

Khatskevich opened this issue Mar 2, 2018 · 0 comments
Labels
code health Improve code readability, simplify maintenance and so on customer enhancement New feature or request prio2 refactoring

Comments

@Khatskevich
Copy link
Contributor

timeout_ms is currently an option of accessor.new()
The point is that passing this parameter to compile is much better, because both simple and huge queries might be created for one accessor, and we want to support different timeouts for this queries.
Khatskevich added a commit that referenced this issue Mar 2, 2018
@Khatskevich
Support query execution timeout
8094acc 
key points:
 - use clock.monotonic64() because it is fast and it changes without
   yields
 - add option `timeout_ms` to accessor.new()
 - after #59 the option should be moved to `tgql.compile()`; see #63

Closes #25
@Khatskevich Khatskevich mentioned this issue Mar 2, 2018
Merged
@Totktonada Totktonada added enhancement New feature or request prio2 labels Mar 2, 2018
Khatskevich added a commit that referenced this issue Mar 5, 2018
@Khatskevich
Support query execution timeout
b398f19 
key points:
 - use clock.monotonic64() because it is fast and it changes without
   yields
 - add option `timeout_ms` to accessor.new()
 - after #59 the option should be moved to `tgql.compile()`; see #63

Closes #25
Khatskevich added a commit that referenced this issue Mar 7, 2018
@Khatskevich
Support query execution timeout
dea44b9 
key points:
 - use clock.monotonic64() because it is fast and it changes without
   yields
 - add option `timeout_ms` to accessor.new()
 - after #59 the option should be moved to `tgql.compile()`; see #63

Closes #25
@Totktonada Totktonada added refactoring code health Improve code readability, simplify maintenance and so on labels Apr 17, 2018
Totktonada added a commit that referenced this issue Apr 18, 2018
@Totktonada
Add accessor's parameters to graphql.new()
dd27668 
It is related to #59. Follow up is needed: #63.
Totktonada added a commit that referenced this issue Jul 5, 2018
@Totktonada
Add options to graphql.compile()
b8a31b2 
The options are:

* resulting_object_cnt_max
* fetched_object_cnt_max
* timeout_ms
* enable_mutations

Fixes #63.
@Totktonada Totktonada mentioned this issue Jul 5, 2018
Merged
Totktonada added a commit that referenced this issue Jul 6, 2018
@Totktonada
Add options to graphql.compile()
db645f7 
The options are:

* resulting_object_cnt_max
* fetched_object_cnt_max
* timeout_ms

Fixes #63.
Totktonada added a commit that referenced this issue Jul 6, 2018
@Totktonada
Add options to graphql.compile()
342c997 
The options are:

* resulting_object_cnt_max
* fetched_object_cnt_max
* timeout_ms

Fixes #63.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
code health Improve code readability, simplify maintenance and so on customer enhancement New feature or request prio2 refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Totktonada @Khatskevich