This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Support query execution timeout #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
approved these changes
Mar 4, 2018
graphql/accessor_general.lua
Outdated
| @@ -864,6 +885,8 @@ function accessor_general.new(opts, funcs) | |||
| DEF_RESULTING_OBJECT_CNT_MAX | |||
| local fetched_object_cnt_max = opts.fetched_object_cnt_max or | |||
| DEF_FETCHED_OBJECT_CNT_MAX | |||
| -- todo: move this setting to `tgql.compile` after #59 | |||
There was a problem hiding this comment.
Use TODO or XXX marks, they highlighted by vim.
graphql/accessor_general.lua
Outdated
| fetched_object_cnt = 0 | ||
| } | ||
| qcontext.deadline_clock = clock.monotonic64() + | ||
| settings.timeout_ms * 1000 * 1000 |
graphql/accessor_general.lua
Outdated
| @@ -864,6 +885,8 @@ function accessor_general.new(opts, funcs) | |||
| DEF_RESULTING_OBJECT_CNT_MAX | |||
| local fetched_object_cnt_max = opts.fetched_object_cnt_max or | |||
| DEF_FETCHED_OBJECT_CNT_MAX | |||
| -- todo: move this setting to `tgql.compile` after #59 | |||
| local timeout_ms = opts.timeout_ms or DEF_TIMEOUT_MS | |||
There was a problem hiding this comment.
I think we should check user-provided input.
|
Added @SudoBobo as optional reviewer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key points:
yields
timeout_msto accessor.new()tgql.compile(); see Move timeout_ms option to compile function #63Closes #25