Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Whether it worth to deduce connection type (1:1 or 1:N) from index parts provided #37

Closed
Totktonada opened this issue Feb 1, 2018 · 3 comments
Labels
archived enhancement New feature or request wontfix This will not be worked on

Comments

@Totktonada
Copy link
Member

The proposal was to consiner:

  • full primary index lookup as unique,
  • partial primary index lookup as non-uniue,
  • full/partial secondary index as non-unique.

I don’t sure we want to reduce flexibility here, like use the unique secondary index as an uniue one. From the other side, for space/shard accessors that affects only result shape: get an object or list of one item which is that object. Need to elaborate how that really constraint us in possible accessor implementations.

The original decision to move indexes description from the graphql part was inspired by feeling that it looks more like accessor’ part, then graphql’s one. But there is possible compromise: link a connection with an index in data accessor, then fetch connection types information in graphql part from the accessor.

@Totktonada Totktonada added prio1 enhancement New feature or request labels Feb 1, 2018
@Totktonada Totktonada added prio3 and removed prio1 labels Feb 9, 2018
@Totktonada
Copy link
Member Author

@SudoBobo Can you please check whether it was done in the scope of #59 and #60?

@Totktonada
Copy link
Member Author

It also should be done as part of #41.

@Totktonada Totktonada added wontfix This will not be worked on archived and removed prio3 labels Apr 13, 2022
@Totktonada
Copy link
Member Author

I'm going to archive the repository. I'll proceed as follows:

  • Mark all open pull requests with the archived label and close.
  • Mark all open issues with archived and wontfix labels and close.
  • Archive the repository.

Consider the following projects:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants