This repository was archived by the owner on Apr 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Return error code in case of an error #134
Labels
Comments
Needed at least the following error codes:
By the way I think that it should be okay to still use error(), but throw an object instead of a string. |
Add one to the list:
|
It seems not so important for now, so I moved it from 0.0.1 milestone. |
|
This also happens when:
|
Totktonada
added a commit
that referenced
this issue
Jun 20, 2018
Success case: {data = ...} Error case: {errors = {message = ..., ...}} compiled_query:execute(...) becomes exception-safe (performs pcall internally), but graphql.new(...):compile() and graphql.new(...).execute(...) still can throw an exception. Enabled 5_2 test in common.test.lua, it fails before fix for #135 ( PR #178). Increased timeout to 10 seconds in pcre.test.lua and nested_args.test.lua (#137). Prerequisite for #71. Prerequisite for #134. Fixes #137.
Totktonada
added a commit
that referenced
this issue
Jun 21, 2018
Success case: {data = ...} Error case: {errors = {message = ..., ...}} compiled_query:execute(...) becomes exception-safe (performs pcall internally), but graphql.new(...):compile() and graphql.new(...).execute(...) still can throw an exception. Enabled 5_2 test in common.test.lua, it fails before fix for #135 ( PR #178). Increased timeout to 10 seconds in pcre.test.lua and nested_args.test.lua (#137). Prerequisite for #71. Prerequisite for #134. Fixes #137.
|
This was referenced Jun 21, 2018
Totktonada
added a commit
that referenced
this issue
Jun 22, 2018
Success case: {data = ...} Error case: {errors = {message = ..., ...}} compiled_query:execute(...) becomes exception-safe (performs pcall internally), but graphql.new(...):compile() and graphql.new(...).execute(...) still can throw an exception. Enabled 5_2 test in common.test.lua, it fails before fix for #135 ( PR #178). Increased timeout to 10 seconds in pcre.test.lua and nested_args.test.lua (#137). Prerequisite for #71. Prerequisite for #134. Fixes #137.
Totktonada
added a commit
that referenced
this issue
Jun 22, 2018
Success case: {data = ...} Error case: {errors = {message = ..., ...}} compiled_query:execute(...) becomes exception-safe (performs pcall internally), but graphql.new(...):compile() and graphql.new(...).execute(...) still can throw an exception. Enabled 5_2 test in common.test.lua, it fails before fix for #135 ( PR #178). Prerequisite for #71. Prerequisite for #134.
Totktonada
added a commit
that referenced
this issue
Jul 2, 2018
Totktonada
added a commit
that referenced
this issue
Jul 2, 2018
Totktonada
added a commit
that referenced
this issue
Jul 2, 2018
Totktonada
added a commit
that referenced
this issue
Jul 2, 2018
Totktonada
added a commit
that referenced
this issue
Jul 2, 2018
Enhance validation and introduce error codes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It would be great to handle errors from graphql accordingly by using error code. Currently is just asserts and returns error message
The text was updated successfully, but these errors were encountered: