This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Enhance validation and introduce error codes #180
Merged
+1,945
−854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
force-pushed
the
gh-134-error-codes
branch
2 times, most recently
from
1e797a9 to
fe77afd
Compare
Success case: {data = ...}
Error case: {errors = {message = ..., ...}}
compiled_query:execute(...) becomes exception-safe (performs pcall
internally), but graphql.new(...):compile() and
graphql.new(...).execute(...) still can throw an exception.
Enabled 5_2 test in common.test.lua, it fails before fix for #135 (
PR #178).
Prerequisite for #71.
Prerequisite for #134.
It is follow up of 8ba78a6.
We lean on gql_wrapper.disable_dangling_check value before, but now we don't.
It is needed to avoid possible name clash with future versions of GraphQL standard. June, 2018 version of the standard strongly recommends to use `extensions` field for custom fields of an error. [1]: https://github.com/facebook/graphql/pull/407/files [2]: https://github.com/facebook/graphql/releases/tag/June2018
Totktonada
force-pushed
the
gh-134-error-codes
branch
from
fe77afd to
69040ca
Compare
Fixed resulting_object_cnt counter in case of a filter by 1:1 connection. Part of #71.
Totktonada
force-pushed
the
gh-134-error-codes
branch
3 times, most recently
from
2c7fc9b to
ebcdd14
Compare
Fixed Int type to be between -2^31 and 2^31-1 instead of -2^32 and 2^32-1. Forbid implicit fraction part removing from Int immediate value. Fixed Long type to forbid variable value of 'number' Lua type that cannot preciselly represent integral value (allow only ones inside -2^53 and 2^53 exclusivelly). Related to #159. Related to #160.
Totktonada
force-pushed
the
gh-134-error-codes
branch
from
079a916 to
9f22717
Compare
It is because the cases use mutation arguments, which is disabled on avro-schema-2*.
Totktonada
force-pushed
the
gh-134-error-codes
branch
from
9f22717 to
9d681cd
Compare
Totktonada
changed the title
Totktonada
force-pushed
the
gh-134-error-codes
branch
from
2efbf58 to
5510e30
Compare
This was referenced Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159.
Fixes #160.
Fixes #134.