Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Add query meta #71

Closed
Khatskevich opened this issue Mar 6, 2018 · 3 comments
Closed

Add query meta #71

Khatskevich opened this issue Mar 6, 2018 · 3 comments
Labels
archived enhancement New feature or request wontfix This will not be worked on

Comments

@Khatskevich
Copy link
Contributor

Khatskevich commented Mar 6, 2018

For testing and debugging purposes, we need more information about a query execution
I suggest at least add:

  1. Used indexes/warnings that indexes were not used
  2. Exec time
  3. Number of retrived objects
  4. Number of returned objects
  5. Number of lookups

Until we do not have strict vision of how it should look like, I suggest add this information in any free form (at least text description, or raw data (index structures themselve)).

@Totktonada
Copy link
Member

We can collect it in qcontext and then create API for accessor_general <-> tarantool_graphql to pass meta and then return it in tarantool_graphql.

@Totktonada Totktonada added enhancement New feature or request prio2 labels Mar 6, 2018
Totktonada added a commit that referenced this issue Jun 20, 2018
Success case: {data = ...}
Error case: {errors = {message = ..., ...}}

compiled_query:execute(...) becomes exception-safe (performs pcall
internally), but graphql.new(...):compile() and
graphql.new(...).execute(...) still can throw an exception.

Enabled 5_2 test in common.test.lua, it fails before fix for #135 (
PR #178).

Increased timeout to 10 seconds in pcre.test.lua and
nested_args.test.lua (#137).

Prerequisite for #71.
Prerequisite for #134.
Fixes #137.
Totktonada added a commit that referenced this issue Jun 21, 2018
Success case: {data = ...}
Error case: {errors = {message = ..., ...}}

compiled_query:execute(...) becomes exception-safe (performs pcall
internally), but graphql.new(...):compile() and
graphql.new(...).execute(...) still can throw an exception.

Enabled 5_2 test in common.test.lua, it fails before fix for #135 (
PR #178).

Increased timeout to 10 seconds in pcre.test.lua and
nested_args.test.lua (#137).

Prerequisite for #71.
Prerequisite for #134.
Fixes #137.
Totktonada added a commit that referenced this issue Jun 22, 2018
Success case: {data = ...}
Error case: {errors = {message = ..., ...}}

compiled_query:execute(...) becomes exception-safe (performs pcall
internally), but graphql.new(...):compile() and
graphql.new(...).execute(...) still can throw an exception.

Enabled 5_2 test in common.test.lua, it fails before fix for #135 (
PR #178).

Increased timeout to 10 seconds in pcre.test.lua and
nested_args.test.lua (#137).

Prerequisite for #71.
Prerequisite for #134.
Fixes #137.
Totktonada added a commit that referenced this issue Jun 22, 2018
Success case: {data = ...}
Error case: {errors = {message = ..., ...}}

compiled_query:execute(...) becomes exception-safe (performs pcall
internally), but graphql.new(...):compile() and
graphql.new(...).execute(...) still can throw an exception.

Enabled 5_2 test in common.test.lua, it fails before fix for #135 (
PR #178).

Prerequisite for #71.
Prerequisite for #134.
Totktonada added a commit that referenced this issue Jun 26, 2018
Fixed resulting_object_cnt counter in case of a filter by 1:1
connection.

Part of #71.
@Totktonada
Copy link
Member

Meta was added, but some information still doesn't provided:

  1. Used indexes/warnings that indexes were not used
  2. Exec time

@Totktonada Totktonada added wontfix This will not be worked on archived and removed prio2 labels Apr 13, 2022
@Totktonada
Copy link
Member

I'm going to archive the repository. I'll proceed as follows:

  • Mark all open pull requests with the archived label and close.
  • Mark all open issues with archived and wontfix labels and close.
  • Archive the repository.

Consider the following projects:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants