This repository was archived by the owner on Apr 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
nested_args test is flaky #137
Labels
Comments
Observed on pcre.test.lua too. |
Totktonada
added a commit
that referenced
this issue
Jun 20, 2018
Success case: {data = ...} Error case: {errors = {message = ..., ...}} compiled_query:execute(...) becomes exception-safe (performs pcall internally), but graphql.new(...):compile() and graphql.new(...).execute(...) still can throw an exception. Enabled 5_2 test in common.test.lua, it fails before fix for #135 ( PR #178). Increased timeout to 10 seconds in pcre.test.lua and nested_args.test.lua (#137). Prerequisite for #71. Prerequisite for #134. Fixes #137.
Totktonada
added a commit
that referenced
this issue
Jun 21, 2018
Success case: {data = ...} Error case: {errors = {message = ..., ...}} compiled_query:execute(...) becomes exception-safe (performs pcall internally), but graphql.new(...):compile() and graphql.new(...).execute(...) still can throw an exception. Enabled 5_2 test in common.test.lua, it fails before fix for #135 ( PR #178). Increased timeout to 10 seconds in pcre.test.lua and nested_args.test.lua (#137). Prerequisite for #71. Prerequisite for #134. Fixes #137.
Totktonada
added a commit
that referenced
this issue
Jun 22, 2018
Success case: {data = ...} Error case: {errors = {message = ..., ...}} compiled_query:execute(...) becomes exception-safe (performs pcall internally), but graphql.new(...):compile() and graphql.new(...).execute(...) still can throw an exception. Enabled 5_2 test in common.test.lua, it fails before fix for #135 ( PR #178). Increased timeout to 10 seconds in pcre.test.lua and nested_args.test.lua (#137). Prerequisite for #71. Prerequisite for #134. Fixes #137.
Totktonada
added a commit
that referenced
this issue
Jun 22, 2018
Tests: pcre.test.lua and nested_args.test.lua. Fixes #137.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Sometimes it fails, sometimes it passes. Maybe timeout time should be extended.
The text was updated successfully, but these errors were encountered: