feat: implement derived-has-same-inputs-outputs
#249
Conversation
🦋 Changeset detectedLatest commit: 02da482 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
baseballyama
force-pushed
the
feature/derived-inputs-outputs
branch
from
4587184 to
69d57b1
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| export default createRule("derived-has-same-inputs-outputs", { | ||
| meta: { | ||
| docs: { | ||
| description: "", |
There was a problem hiding this comment.
description must be set.
| description: "", | |
| description: "derived store should use same variable names between values and callback", |
| meta: { | ||
| docs: { | ||
| description: "", | ||
| category: "Best Practices", |
There was a problem hiding this comment.
Perhaps "Stylistic Issues" is a more appropriate category.
| category: "Best Practices", | |
| category: "Stylistic Issues", |
There was a problem hiding this comment.
updated! ba6dccc
conflictWithPrettier should be false right?🤔
| loc: { | ||
| start: fnParam.loc?.start ?? { line: 1, column: 0 }, | ||
| end: fnParam.loc?.end ?? { line: 1, column: 0 }, | ||
| }, |
There was a problem hiding this comment.
Nodes handled by ESLint always have a loc property, so non-null expressions can be used.
https://eslint.org/docs/latest/developer-guide/working-with-custom-parsers#all-nodes
| loc: { | |
| start: fnParam.loc?.start ?? { line: 1, column: 0 }, | |
| end: fnParam.loc?.end ?? { line: 1, column: 0 }, | |
| }, | |
| loc: fnParam.loc!, |
There was a problem hiding this comment.
fixed! ba6dccc
And my previous PR also should do the same way, so I updated it.
| }) | ||
| fnParam.elements.forEach((element, index) => { | ||
| if (element && element.type === "Identifier") { | ||
| const expectedName = `$${argNames[index]}` |
There was a problem hiding this comment.
I think maybe if argNames[index] is null it should be ignored from the check.
There was a problem hiding this comment.
Sorry for that! I updated! ba6dccc
| loc: { | ||
| start: element.loc?.start ?? { line: 1, column: 0 }, | ||
| end: element.loc?.end ?? { line: 1, column: 0 }, | ||
| }, |
There was a problem hiding this comment.
| loc: { | |
| start: element.loc?.start ?? { line: 1, column: 0 }, | |
| end: element.loc?.end ?? { line: 1, column: 0 }, | |
| }, | |
| loc: element.loc!, |
There was a problem hiding this comment.
fixed! ba6dccc
And my previous PR also should do the same way, so I updated.
|
@ota-meshi And I added a few more tests. Thank you for your review! |
Related to: #198 (derived-inputs-outputs)