Skip to content

Commit ba6dccc

Browse files
committed
chore: update according to review comments
1 parent 69d57b1 commit ba6dccc

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

src/rules/derived-has-same-inputs-outputs.ts

+9-12
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,11 @@ import { extractStoreReferences } from "./reference-helpers/svelte-store"
66
export default createRule("derived-has-same-inputs-outputs", {
77
meta: {
88
docs: {
9-
description: "",
10-
category: "Best Practices",
9+
description:
10+
"derived store should use same variable names between values and callback",
11+
category: "Stylistic Issues",
1112
recommended: false,
13+
conflictWithPrettier: false,
1214
},
1315
schema: [],
1416
messages: {
@@ -52,10 +54,7 @@ export default createRule("derived-has-same-inputs-outputs", {
5254
if (expectedName !== fnParam.name) {
5355
context.report({
5456
node: fn,
55-
loc: {
56-
start: fnParam.loc?.start ?? { line: 1, column: 0 },
57-
end: fnParam.loc?.end ?? { line: 1, column: 0 },
58-
},
57+
loc: fnParam.loc!,
5958
messageId: "unexpected",
6059
data: { name: expectedName },
6160
})
@@ -77,15 +76,13 @@ export default createRule("derived-has-same-inputs-outputs", {
7776
return element && element.type === "Identifier" ? element.name : null
7877
})
7978
fnParam.elements.forEach((element, index) => {
80-
if (element && element.type === "Identifier") {
81-
const expectedName = `$${argNames[index]}`
79+
const argName = argNames[index]
80+
if (element && element.type === "Identifier" && argName) {
81+
const expectedName = `$${argName}`
8282
if (expectedName !== element.name) {
8383
context.report({
8484
node: fn,
85-
loc: {
86-
start: element.loc?.start ?? { line: 1, column: 0 },
87-
end: element.loc?.end ?? { line: 1, column: 0 },
88-
},
85+
loc: element.loc!,
8986
messageId: "unexpected",
9087
data: { name: expectedName },
9188
})

src/rules/no-store-async.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export default createRule("no-store-async", {
3232
continue
3333
}
3434

35-
const start = fn.loc?.start ?? { line: 1, column: 0 }
35+
const start = fn.loc!.start
3636
context.report({
3737
node: fn,
3838
loc: {

0 commit comments

Comments
 (0)