Skip to content

chore: remove unused vetur settings #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

baseballyama
Copy link
Member

This repo doesn't need to use vetur, so I removed it.

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2022

⚠️ No Changeset found

Latest commit: e89b1fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@baseballyama
Copy link
Member Author

Hum... Why type error comes...

@JounQin
Copy link
Collaborator

JounQin commented Sep 3, 2022

error @sveltejs/[email protected]: The engine "node" is incompatible with this module. Expected version ">=16.14". Got "16.13.0"
error Found incompatible module.

Let's wait for #247 first

@baseballyama
Copy link
Member Author

But still, I didn't get why suddenly type error comes from cacheable-request...?

https://github.com/ota-meshi/eslint-plugin-svelte/runs/8166580394?check_suite_focus=true#step:5:16

Error: node_modules/@types/cacheable-request/index.d.ts(26,42): error TS2709: Cannot use namespace 'ResponseLike' as a type.

@JounQin
Copy link
Collaborator

JounQin commented Sep 3, 2022

Because we're not using lock files?

@baseballyama
Copy link
Member Author

cacheable-request is not updated recently. So I think type is not changed compared to other recent PRs even without lock files. This is weird...

@JounQin
Copy link
Collaborator

JounQin commented Sep 3, 2022

I could also be affected by other global types or TypeScript itself.

@baseballyama
Copy link
Member Author

To avoid cacheable-request type error, I added skipLibCheck option to tsconfig.json.
I'm not sure this is the proper way, but now build and lint are succeeded.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM! Thank you!

@ota-meshi ota-meshi merged commit 76ebfca into sveltejs:main Sep 3, 2022
@baseballyama baseballyama deleted the chore/vscode-setting branch September 4, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants