Skip to content

chore: upgrade svelte kit and migration work #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

chore: upgrade svelte kit and migration work #247

merged 1 commit into from
Sep 5, 2022

Conversation

ota-meshi
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2022

⚠️ No Changeset found

Latest commit: 485d282

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin JounQin mentioned this pull request Sep 3, 2022
Merged
JounQin
JounQin requested changes Sep 3, 2022
View reviewed changes
package.json
"@sveltejs/adapter-static": "^1.0.0-next.26",
"@sveltejs/kit": "^1.0.0-next.406",
"@sveltejs/adapter-static": "^1.0.0-next.40",
"@sveltejs/kit": "^1.0.0-next.456",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#248

It seems kit has new breaking changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR addresses a breaking change in the kit. Were there other tasks that needed to be done?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #248 (comment) resolved in this PR?

Copy link
Member Author

@ota-meshi ota-meshi Sep 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was a codesandbox issue PR below should have fixed it. I am writing a comment in PR.

https://github.com/ota-meshi/eslint-plugin-svelte/pull/244/files#diff-bca34ff1efba1992c546adca0b1596996778b69817a7c391d29f40806694fdc9R2

@baseballyama
Copy link
Member

baseballyama commented Sep 3, 2022 •
edited
Loading

prerender.default also we need to remove.
Sorry missed seeing that already removed.

@baseballyama baseballyama mentioned this pull request Sep 3, 2022
Merged
@ota-meshi ota-meshi requested a review from JounQin September 5, 2022 07:51
@ota-meshi ota-meshi merged commit 1690371 into main Sep 5, 2022
@ota-meshi ota-meshi deleted the svelte-kit branch September 5, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JounQin JounQin JounQin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ota-meshi @baseballyama @JounQin