Skip to content

chore: upgrade svelte kit and migration work #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2022
Merged

chore: upgrade svelte kit and migration work #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs-svelte-kit/src/routes/+layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { markdownPath } from "$lib/utils.js"
const docs = import.meta.glob("../../../docs/**/*.md")

export const prerender = true

/** @type {import('@sveltejs/kit').Load} */
export async function load({ url }) {
const markdown = `../../../docs/${markdownPath(url.pathname)}`
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@
"@fontsource/fira-mono": "^4.5.0",
"@ota-meshi/eslint-plugin": "^0.12.0",
"@sindresorhus/slugify": "^2.1.0",
"@sveltejs/adapter-static": "^1.0.0-next.26",
"@sveltejs/kit": "^1.0.0-next.406",
"@sveltejs/adapter-static": "^1.0.0-next.40",
"@sveltejs/kit": "^1.0.0-next.456",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#248

It seems kit has new breaking changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR addresses a breaking change in the kit. Were there other tasks that needed to be done?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #248 (comment) resolved in this PR?

Copy link
Member Author

@ota-meshi ota-meshi Sep 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was a codesandbox issue PR below should have fixed it. I am writing a comment in PR.

https://github.com/ota-meshi/eslint-plugin-svelte/pull/244/files#diff-bca34ff1efba1992c546adca0b1596996778b69817a7c391d29f40806694fdc9R2

"@types/babel__core": "^7.1.19",
"@types/cross-spawn": "^6.0.2",
"@types/escape-html": "^1.0.2",
Expand Down
5 changes: 1 addition & 4 deletions svelte.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,9 @@ const config = {
pages: outDir,
assets: outDir,
}),
prerender: {
default: true,
},
files: {
routes: path.join(dirname, "./docs-svelte-kit/src/routes"),
template: path.join(dirname, "./docs-svelte-kit/src/app.html"),
appTemplate: path.join(dirname, "./docs-svelte-kit/src/app.html"),
hooks: path.join(dirname, "./docs-svelte-kit/src/hooks"),
lib: path.join(dirname, "./docs-svelte-kit/src/lib"),
assets: path.join(dirname, "./docs-svelte-kit/statics"),
Expand Down