Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

MicroMod SAMD51 support #138

Merged
merged 22 commits into from
Oct 27, 2020
Merged

MicroMod SAMD51 support #138

merged 22 commits into from
Oct 27, 2020

Conversation

nseidle
Copy link
Member

@nseidle nseidle commented Oct 26, 2020

This PR adds a platform guard for MicroMod SAMD51. Otherwise, the lib fails to compile complaining about no SerialUSB defined.

nseidle and others added 20 commits October 23, 2020 09:21
Because I like it when people spell SparkFun correctly.
When a user wants to make a module configuration change they probably want the change to take effect immediately. The previous default of BBR didn't do a lot of good.

I am also experimenting with generating key groups using defines.
Add support for TMOD3 fixed position.
@nseidle nseidle requested review from PaulZC and edspark October 26, 2020 19:07
@edspark
Copy link
Contributor

edspark commented Oct 26, 2020

I did a simple compilation check using the examples contained within the library and found that it did fix the preproccessor error with SERIALUSB.

Copy link
Contributor

@edspark edspark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll comment here in the proper place. I confirmed that this does in fact fix the preprocessor error with SerialUSB.

@nseidle nseidle merged commit 97bd455 into master Oct 27, 2020
@PaulZC PaulZC deleted the MicroMod_SAMD51-Support branch October 30, 2020 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants