Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Change Ublox to u-blox #133

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Change Ublox to u-blox #133

merged 2 commits into from
Oct 26, 2020

Conversation

nseidle
Copy link
Member

@nseidle nseidle commented Oct 23, 2020

Because I like it when people spell SparkFun correctly.

Text changes only. Compiles and works. My only concern is that I've changed the title in lib.prop but that the library name can be different from the Github repo name. So just a reminder to check once released.

Because I like it when people spell SparkFun correctly.
@adamgarbo
Copy link
Contributor

Oh my gosh. Yes!

It was one of the first things I did when I forked the OpenLog Artemis GNSS Logger repository. I slept so much better afterward. 😉

@nseidle
Copy link
Member Author

nseidle commented Oct 23, 2020

Hah! OCD united.

@adamgarbo
Copy link
Contributor

By the way, small "u-bblox" typo in library.properties! Phew, glad I was able to catch it!

@nseidle
Copy link
Member Author

nseidle commented Oct 23, 2020

Phew! That was close. Thanks! :)

@nseidle nseidle requested a review from PaulZC October 23, 2020 19:01
@nseidle nseidle changed the base branch from master to release_candidate October 23, 2020 19:49
Copy link
Collaborator

@PaulZC PaulZC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PaulZC PaulZC merged commit 7114584 into release_candidate Oct 26, 2020
@PaulZC
Copy link
Collaborator

PaulZC commented Oct 26, 2020

@nseidle: All good. Please delete the branch at your leisure!

@nseidle nseidle deleted the UBloxTextChange branch October 26, 2020 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants