This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Add support for TMOD3 fixed position. #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulZC
suggested changes
Oct 26, 2020
There was a problem hiding this comment.
Hi @nseidle ,
Apologies. I had finger trouble and have submitted a blank review before this one. Please ignore that one.
This is great but I suggest renaming the function parameters to reflect that they can be ECEF or Lat/Lon/Alt (see below).
Cheers,
Paul
examples/ZED-F9P/Example11_setStaticPosition/Example11_setStaticPosition.ino
Outdated
Show resolved
Hide resolved
examples/ZED-F9P/Example11_setStaticPosition/Example11_setStaticPosition.ino
Show resolved
Hide resolved
examples/ZED-F9P/Example11_setStaticPosition/Example11_setStaticPosition.ino
Outdated
Show resolved
Hide resolved
|
I think all changes are committed. Please have a look at your convenience. |
PaulZC
approved these changes
Oct 26, 2020
|
Nice one - thank you! Please merge and delete branch at your convenience... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are times when I need to set the static position of the receiver CFG-TMODE3 so I added setStaticPosition.
This PR:
I think this is a good example of a function that should be converted to set/getVals. The ZED is pretty much the first receiver to support TMODE3 so we don't have to worry about <v27 protocol issues. The function would go from 50 lines to perhaps 8 and remove the need for read/modify/write steps (faster!).