Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

v1.8.7 Release candidate #137

Merged
merged 27 commits into from
Oct 27, 2020
Merged

v1.8.7 Release candidate #137

merged 27 commits into from
Oct 27, 2020

Conversation

nseidle
Copy link
Member

@nseidle nseidle commented Oct 26, 2020

This PR:

  • Adds getVal16 and getVal32
  • Expands get/setVal examples
  • Paves a path forward for hard-coded key values in a separate header file
  • Updates the spelling of u-blox in library files
  • Adds method for setting fixed position of module (TMODE3)

@nseidle nseidle requested a review from PaulZC October 26, 2020 18:18
@nseidle
Copy link
Member Author

nseidle commented Oct 26, 2020

Please don't merge until we get the library version rolled to 1.8.7 (separate PR - is there an easier way to get that in place?)

@PaulZC
Copy link
Collaborator

PaulZC commented Oct 26, 2020

I normally just update everything in the release_candidate branch, including updating library.properties (as you've just done), then merge into master and then issue a new release of master. I don't think there's an easier way of doing it?
I think you can safely remove the auto-review-request on the release-candidate branch? Assuming there is one? If these are all manually-requested reviews then that's perfectly fine! But having a mandatory review in place on master seems sensible, so long as it doesn't slow us down too much...
I think I've checked all of your updates in the individual PR's but I'll give this one another look through just in case. Probably won't be until tomorrow though. It's dinner time over here!
All the best,
Paul

@nseidle
Copy link
Member Author

nseidle commented Oct 26, 2020

Good point. Restrictions removed from release-candidate so we can be more flexible.

No rush. Enjoy!

Copy link
Collaborator

@PaulZC PaulZC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two points:
One missing "b". Yes, really... (Just to prove I did look at the code!) :-D
And a question about the format of the keys. Should they be #defines or const uint32_t?
I've attached files that contain the full list in both formats. Please take your pick!

@nseidle
Copy link
Member Author

nseidle commented Oct 27, 2020

I think we're closer to merge. I'm happy to leave this PR open until issue 131 is resolved, or we can merge without it. Up to you Paul.

@PaulZC
Copy link
Collaborator

PaulZC commented Oct 27, 2020

I think we're ready? I've just updated the example as Morten suggested. It's a lot better now.

@nseidle nseidle merged commit 49224fa into master Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants