Skip to content

Change to poetry command to export requirements.txt resolving #445 #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2020

Conversation

JoeyC1990
Copy link
Contributor

Hi, Here is the first attempt at fixing the change in the poetry export command.

The change needed was detailed here: https://python-poetry.org/docs/cli/#export

@JoeyC1990
Copy link
Contributor Author

I have now made this change so hopefully this is ready to be merged

@jimpudar
Copy link

jimpudar commented Jan 7, 2020

I would also love for this to be merged. Currently relying on a workaround for this issue.

@jimpudar
Copy link

There's also a corresponding change in the README which needs to be made that references this change.

https://github.com/UnitedIncome/serverless-python-requirements/blob/master/README.md#poetry-support-sparklespencilsparkles

Also, bump - this is a pretty huge issue that prevents anyone using Poetry with this plugin!

@JoeyC1990
Copy link
Contributor Author

I have updated the readme so this is now ready to push @dschep please can this be merged?

@wozniakty
Copy link

Yeah, this is completely blocking my current project from using poetry :(

@bsamuel-ui bsamuel-ui merged commit ce466f9 into serverless:master Feb 14, 2020
@JoeyC1990 JoeyC1990 deleted the Poetry1Update branch February 14, 2020 20:34
@miketheman
Copy link
Contributor

This change to require the use of -o flag has broken CI, as the -o flag was not present in poetry version 1.0.0a0 - and a specific test was added in #395 to enable testing against the older version, which has since been overridden here.

There's a few paths forward that I can think of:

  1. Reverse the approach taken here and revert to using stdout and redirection.
  2. Add poetry version detection logic and try to use redirection if detected.
  3. Remove the test for pre-release poetry version, and commit to the stability of version 1.0.0 which supports the -o flag.

I'm leaning towards the final one - this is likely the last bit before we can have a full CI pass again - I've been working through that on #462

@bsamuel-ui
Copy link
Contributor

I agree with dropping support for prerelease poetry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants