Skip to content

poetry and private repositories #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
username-dot-com opened this issue Sep 18, 2019 · 3 comments
Closed

poetry and private repositories #407

username-dot-com opened this issue Sep 18, 2019 · 3 comments

Comments

@username-dot-com
Copy link

Poetry doesnt output extra index urls for having pip look at other repositories for packages by default with the export command. The --with-credentials flag must be set for the export command to put the extra index urls into the requirements.txt output. This broke my team's serverless deploy step since packaging couldn't be completed, because pip couldnt find the dependencies that were stored in our private pypi server.

I've currently worked around this issue by specifying our pypi source in PIP_EXTRA_INDEX_URL environment variable. I'm not sure this would work for people who need multiple extra sources though.

It seems an easy enough fix: use the --with-credentials flag when calling poetry export, and I'm willing to create a pr for this, unless there are repercussions to this change I'm not seeing.

@username-dot-com
Copy link
Author

username-dot-com commented Sep 18, 2019

Now that I think about it, adding that command option would break back compat with the 1.0.0a5 release if that matters?

@miketheman
Copy link
Contributor

Hi @username-dot-com ! Thanks for offering to add that functionality.
We recently discussed poetry backwards compat in #446 (comment), and decided that we're oOK not supporting pre-1.0.0.

If you wanted to create a PR with some tests (CircleCI is the one to watch), we'd appreciate it!

@username-dot-com
Copy link
Author

Sounds good. I'm pretty busy this week, but I should be able to get on this by sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants