-
Notifications
You must be signed in to change notification settings - Fork 293
Fix poetry 1.0.0b1 export prints to stdout by default #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix poetry 1.0.0b1 export prints to stdout by default #395
Conversation
227b209
to
835ef2f
Compare
Will this break older versions of Poetry? Is there any solution that works with old and new versions? |
Sorry for my lack of consideration. I'll think about it a little more. |
circleci is working? I set up circleci setting in my forked repository before. Is that bad? I corrected code for now. |
Did you test it with an older version? I'm just wondering if it truly outputs nothing or still has a newline? (in which case, you can just add
nah, that's fine. |
Yes, I test it with an older version and working. But I think I should add .trim() too. |
Awesome. Thanks! I'll merge as soon as circle finishes |
Hmm. it does seem seting up circle might have caused issues :( |
Thank you for your kindness! |
looks circle is running! I pray to pass the tests. |
I'm sorry if this was posted elsewhere, but when will this get into an npm release? |
The test was introduced to test the behavior of a particular pre-release version of poetry, prior to version 1.0.0 being released. It has since been released on Dec 12, 2019. Refs: https://python-poetry.org/blog/announcing-poetry-1-0-0.html Refs: serverless#395 Signed-off-by: Mike Fiedler <[email protected]>
The test was introduced to test the behavior of a particular pre-release version of poetry, prior to version 1.0.0 being released. It has since been released on Dec 12, 2019. Refs: https://python-poetry.org/blog/announcing-poetry-1-0-0.html Refs: serverless#395 Signed-off-by: Mike Fiedler <[email protected]>
The
export
command for poetry 1.0.0b1 outputs to standard output if the-o
option is not specified.Modified to use
spawnSync
return values.