Skip to content

Fix poetry 1.0.0b1 export prints to stdout by default #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2019

Conversation

mokamoto12
Copy link
Contributor

The export command for poetry 1.0.0b1 outputs to standard output if the -o option is not specified.

Modified to use spawnSync return values.

@dschep
Copy link
Contributor

dschep commented Aug 12, 2019

Will this break older versions of Poetry? Is there any solution that works with old and new versions?

@mokamoto12
Copy link
Contributor Author

Sorry for my lack of consideration. I'll think about it a little more.
Please let me know if you have any ideas!

@mokamoto12
Copy link
Contributor Author

mokamoto12 commented Aug 12, 2019

circleci is working? I set up circleci setting in my forked repository before. Is that bad?

I corrected code for now.

@dschep
Copy link
Contributor

dschep commented Aug 12, 2019

Did you test it with an older version? I'm just wondering if it truly outputs nothing or still has a newline? (in which case, you can just add .trim() after the .toString().

circleci is working? I set up circleci setting in my forked repository before. Is that bad?

nah, that's fine.

@mokamoto12
Copy link
Contributor Author

Did you test it with an older version? I'm just wondering if it truly outputs nothing or still has a newline? (in which case, you can just add .trim() after the .toString().

Yes, I test it with an older version and working. But I think I should add .trim() too.
I fixed it and add a test.

@dschep
Copy link
Contributor

dschep commented Aug 12, 2019

Awesome. Thanks! I'll merge as soon as circle finishes

@dschep
Copy link
Contributor

dschep commented Aug 12, 2019

Hmm. it does seem seting up circle might have caused issues :(

@mokamoto12
Copy link
Contributor Author

Thank you for your kindness!
But I'm worried if circle job is not running. I am sorry if I have a problem. Please let me know if there is my task.

@mokamoto12
Copy link
Contributor Author

looks circle is running! I pray to pass the tests.
I will be careful to not setting up circle in a forked repository.

@dschep dschep merged commit 7d3e263 into serverless:master Aug 12, 2019
@mokamoto12 mokamoto12 deleted the adjust-poetry1.0.0b1-export branch August 13, 2019 02:46
@username-dot-com
Copy link

I'm sorry if this was posted elsewhere, but when will this get into an npm release?

miketheman added a commit to miketheman/serverless-python-requirements that referenced this pull request Feb 18, 2020
The test was introduced to test the behavior of a particular pre-release
version of poetry, prior to version 1.0.0 being released.
It has since been released on Dec 12, 2019.

Refs: https://python-poetry.org/blog/announcing-poetry-1-0-0.html
Refs: serverless#395

Signed-off-by: Mike Fiedler <[email protected]>
miketheman added a commit to miketheman/serverless-python-requirements that referenced this pull request Feb 18, 2020
The test was introduced to test the behavior of a particular pre-release
version of poetry, prior to version 1.0.0 being released.
It has since been released on Dec 12, 2019.

Refs: https://python-poetry.org/blog/announcing-poetry-1-0-0.html
Refs: serverless#395

Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants