Skip to content

does not work with poetry 1.0.0b1 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasonkuhrt opened this issue Aug 9, 2019 · 4 comments · Fixed by #402
Closed

does not work with poetry 1.0.0b1 #393

jasonkuhrt opened this issue Aug 9, 2019 · 4 comments · Fixed by #402

Comments

@jasonkuhrt
Copy link

Apps have started to fail at deploy with error like:

  ENOENT: no such file or directory, link '/Users/jasonkuhrt/projects/dialoguemd/beautiful-mind/mattermost-posts-consumer/requirements.txt' -> '/Users/jasonkuhrt/projects/dialoguemd/beautiful-mind/mattermost-posts-consumer/.serverless/requirements.txt'

Reason we found was that poetry had been upgraded to latest preview version, 1.0.0b1. Rolling poetry back to 1.0.0a5 resolved the issue. Creating issue here but it may be that it belongs on poetry side.

@mokamoto12
Copy link
Contributor

The default behavior of the poetry export has changed.
If the -o option is not specified, the contents are printed to standard output.

This problem will be fixed in #395

@tpansino
Copy link
Contributor

@jasonkuhrt have you verified that the fix in #395 fixes your issue? I still see this happening when I run with master installed.

I'm not very skilled at Javascript, but having worked on this section of code in the last month on #390, I think the real root-cause is this line. It seems that the poetry export this code runs dumps the file in whatever the current directory is, then attempts to move it into .serverless, but without the { "overwrite": true } parameter dict passed to this moveSync method it fails silently when the destination file already exists.

I've tested this override and it seems to work as a fix. Someone tell me if my assumptions are wrong here, otherwise I'll open a PR for this fix.

@tpansino
Copy link
Contributor

Also, just to mention, the best way I've found to reproduce this issue is to serverless deploy, twice. The first time creates the file and the second time causes the conflict where it can't be overwritten. Removing the two files mentioned in the error always fixes the problem, as does adding the overwrite flag as I have done in my PR.

@bsamuel-ui
Copy link
Contributor

Closed as #395 is merged. Happy to reopen if there are still issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants