Fix poetry with git dependencies #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpansino
commented
Jul 31, 2019
test.js
Outdated
| @@ -727,7 +727,8 @@ test('poetry py3.6 can package flask with default options', t => { | |||
| sls(['package']); | |||
| const zipfiles = listZipFiles('.serverless/sls-py-req-test.zip'); | |||
| t.true(zipfiles.includes(`flask${sep}__init__.py`), 'flask is packaged'); | |||
| t.true(zipfiles.includes(`boto3${sep}__init__.py`), 'boto3 is packaged'); | |||
| t.true(zipfiles.includes(`bottle.py`), 'bottle is packaged'); | |||
| t.false(zipfiles.includes(`boto3${sep}__init__.py`), 'boto3 is NOT packaged'); | |||
There was a problem hiding this comment.
@jaysonsantos This assertion change you made seems incorrect given that the pyproject.toml has boto3 = "^1.9" specified. I would expect boto3 to be packaged. Am I missing something about what this test is supposed to be checking?
I'm going to change it back for now.
|
@dschep Is there something I need to do to get the |
|
Hey there, sorry I could not answer before because I was in vacations :D. |
This was referenced Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a copy of #362, but with tests fixed.