-
Notifications
You must be signed in to change notification settings - Fork 293
Fix poetry with git dependencies #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
21508d3
Make sure that pip errors show stdout and stderr
jaysonsantos 16d0fa1
Make tests break with git dependencies
jaysonsantos 5dc20c5
Fix poetry generated requirements.txt for git dependencies
jaysonsantos 023033e
Fix wrongly expected file in test
jaysonsantos 5586121
Add disclaimer about poetry and git dependencies
jaysonsantos 5029548
Run prettier on poetry.js
jaysonsantos eea44ec
Rename editableLine -> editableFlag
a10d29a
Switch to https proto for poetry testing and re-lock
da2db0b
README update
9981ba2
Fix seemingly incorrect test assertion
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -110,6 +110,26 @@ custom: | |
usePoetry: false | ||
``` | ||
|
||
### Poetry with git dependencies | ||
Poetry by default generates the exported requirements.txt file with `-e` and that breaks pip with `-t` parameter | ||
(used to install all requirements in a specific folder). In order to fix that we remove all `-e ` from the generated file but, | ||
for that to work you need to add the git dependencies in a specific way. | ||
|
||
Instead of: | ||
```toml | ||
[tool.poetry.dependencies] | ||
bottle = {git = "[email protected]/bottlepy/bottle.git", tag = "0.12.16"} | ||
``` | ||
Use: | ||
```toml | ||
[tool.poetry.dependencies] | ||
bottle = {git = "https://[email protected]/bottlepy/bottle.git", tag = "0.12.16"} | ||
``` | ||
Or, if you have an SSH key configured: | ||
```toml | ||
[tool.poetry.dependencies] | ||
bottle = {git = "ssh://[email protected]/bottlepy/bottle.git", tag = "0.12.16"} | ||
``` | ||
|
||
## Dealing with Lambda's size limitations | ||
To help deal with potentially large dependencies (for example: `numpy`, `scipy` | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ authors = ["Your Name <[email protected]>"] | |
[tool.poetry.dependencies] | ||
python = "^3.6" | ||
Flask = "^1.0" | ||
bottle = "^0.12.16" | ||
bottle = {git = "https://[email protected]/bottlepy/bottle.git", tag = "0.12.16"} | ||
boto3 = "^1.9" | ||
|
||
[tool.poetry.dev-dependencies] | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaysonsantos This assertion change you made seems incorrect given that the
pyproject.toml
hasboto3 = "^1.9"
specified. I would expectboto3
to be packaged. Am I missing something about what this test is supposed to be checking?I'm going to change it back for now.