Skip to content

Prevent serverless package hash from changing #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

mokamoto12
Copy link
Contributor

Modify the following to prevent modification of the serverless deploy package file hash.

  • Inserting packages asynchronously changes the order
  • The timestamp is changed when creating a folder in the package zip file with jszip

Changing the file hash will cause unnecessary deployment.

I'm sorry my English is not good.

@dschep
Copy link
Contributor

dschep commented Aug 12, 2019

Makes sense. looks good to me!

@dschep
Copy link
Contributor

dschep commented Aug 12, 2019

seems like tests fail tho.

@mokamoto12
Copy link
Contributor Author

Thank you for your approval!
I think circleci's test failure is caused by #395, I try to fix it.
Sorry, I'm not familiar with appveyor. I don't know the cause.

@dschep
Copy link
Contributor

dschep commented Aug 12, 2019

I think circleci's test failure is caused by #395, I try to fix it.

ah. i see.

Sorry, I'm not familiar with appveyor. I don't know the cause.

dont worry about it

@mokamoto12
Copy link
Contributor Author

Test failure is fixed. I am sorry to trouble you, but could you add a job for the circle?
I'm looking forward to this release!

@dschep
Copy link
Contributor

dschep commented Aug 13, 2019

yup! hopefully we'll be moving to github actions soon anyway 😁

@dschep dschep merged commit dddea23 into serverless:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants