chore(ci): get CI working again #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 6.x has been EOL since April 2019, and Node 8.x becaome EOL in Dec 2019. This pushes the CI environment to use an Active LTS version of Node. Refs: https://github.com/nodejs/Release Signed-off-by: Mike Fiedler <[email protected]>
Uncertain of why this is currently failing - it's possible the global version of node in the `circleci/classic` image is incompatible - that should be investigated independently. In the meantime, the rest of CI isn't being run. Signed-off-by: Mike Fiedler <[email protected]>
These un-linted changes have crept in due to lack of CI making it here. Signed-off-by: Mike Fiedler <[email protected]>
Appveyor testing is failing due to a warning during installation of the `serverless` package, since the `fsevents` dependency is targeting the `darwin` architecture. Signed-off-by: Mike Fiedler <[email protected]>
miketheman
changed the title
The test was introduced to test the behavior of a particular pre-release version of poetry, prior to version 1.0.0 being released. It has since been released on Dec 12, 2019. Refs: https://python-poetry.org/blog/announcing-poetry-1-0-0.html Refs: serverless#395 Signed-off-by: Mike Fiedler <[email protected]>
miketheman
force-pushed
the
miketheman/update-node-version
branch
from
ecef22b to
ca2bfc1
Compare
Update to run against Python 3.x instead of EOL 2.x Signed-off-by: Mike Fiedler <[email protected]>
|
Here's the good news: CircleCI is passing now! So a couple of things we could do here: a. remove appveyor as a testing target for now - how well do we trust the Windows/Python/Node/Docker setup? |
bsamuel-ui
approved these changes
Feb 18, 2020
|
Good lord, I didn't realize we were building python on Circle. |
|
Yeah, we can improve! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a simple version update, but I found more things that needed fixing before we can get back to a full CI run again.
Please review by commit.
Signed-off-by: Mike Fiedler [email protected]