Sync with the stable documentation branch #17466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
small change I forgot to copy over
This should provide more insight on why #17119 happens.
follows #17334 which was merged
fixes #17421 After:  @szymon-rd I was not sure who to assign to, or which branch to use
|
we need to drop the changes from 86a3bec, but it seems that commit was necessary to run the CI on language-reference-stable? |
|
@bishabosha the tests do not seem to have been triggered correctly. Probably due to https://www.githubstatus.com/incidents/nf7s6933tnn8. |
|
maybe - but this PR shouldn't include 86a3bec anyway - and I assume its going to be included in every sync PR from now on :/ |
|
I think it is okay to merge since the following changes will be applied: main...language-reference-stable. Edit: screenshot below.
|
julienrf
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is syncing the main with changes from language-reference-stable.
It was created automatically after 28fec6b by @bishabosha