Skip to content

[docs] Typeclass Derivation no longer recommends given derived[T]: TC[T] #17414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2023
Merged

[docs] Typeclass Derivation no longer recommends given derived[T]: TC[T] #17414

merged 3 commits into from
May 5, 2023

Conversation

bishabosha
Copy link
Member

fixes #16916

@bishabosha bishabosha requested a review from sjrd May 4, 2023 14:24
@bishabosha bishabosha changed the base branch from main to language-reference-stable May 4, 2023 14:24
@bishabosha bishabosha requested a review from julienrf May 4, 2023 14:25
@bishabosha bishabosha mentioned this pull request May 4, 2023
Closed
@bishabosha bishabosha force-pushed the improve-derivation-docs branch from d44fcef to 10dac05 Compare May 4, 2023 14:28
sjrd
sjrd requested changes May 4, 2023
View reviewed changes
sideeffffect
sideeffffect reviewed May 4, 2023
View reviewed changes
sideeffffect
sideeffffect reviewed May 4, 2023
View reviewed changes
@bishabosha bishabosha force-pushed the improve-derivation-docs branch from 10dac05 to 8eb11f9 Compare May 4, 2023 18:54
@bishabosha bishabosha requested a review from sjrd May 4, 2023 18:55
@bishabosha
Copy link
Member Author

bishabosha commented May 4, 2023 •
edited
Loading

@sjrd in the force push I also added some motivation for why derived should not be given

@bishabosha bishabosha force-pushed the improve-derivation-docs branch from 8eb11f9 to 6cb9d59 Compare May 4, 2023 18:57
julienrf
julienrf reviewed May 5, 2023
View reviewed changes
@bishabosha bishabosha requested a review from julienrf May 5, 2023 09:27
@bishabosha bishabosha assigned julienrf and unassigned sjrd May 5, 2023
julienrf
julienrf approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the improvements!

@julienrf julienrf assigned bishabosha and unassigned julienrf May 5, 2023
@bishabosha bishabosha merged commit bd9e0f7 into scala:language-reference-stable May 5, 2023
@bishabosha bishabosha deleted the improve-derivation-docs branch May 5, 2023 09:33
@bishabosha bishabosha mentioned this pull request May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

@sideeffffect sideeffffect sideeffffect left review comments

@julienrf julienrf julienrf approved these changes

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Derivation Works Without Derives Clause
4 participants
@bishabosha @julienrf @sjrd @sideeffffect