Skip to content

fix(docs): make sure link is correct on fewer braces page #17417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2023

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented May 4, 2023

No description provided.

@mbovel mbovel requested a review from Kordyjan May 8, 2023 12:08
@SethTisue
Copy link
Member

should this page even still exist, with 3.3.0 imminent?

@ckipp01
Copy link
Member Author

ckipp01 commented May 11, 2023

should this page even still exist, with 3.3.0 imminent?

Good question. How does this typically work with experimental features? I'm assuming we remove those pages prior to the release when the feature becomes mainline?

I also realize now I should probably be targeting language-refernce-stable instead of main.

@julienrf
Copy link
Contributor

julienrf commented May 19, 2023

How does this typically work with experimental features? I'm assuming we remove those pages prior to the release when the feature becomes mainline?

In general, I am a proponent of keeping old URLs working. So, instead of removing the page, I prefer keeping it with a link to the new page. (An alternative could be to add a redirectFrom field in the front matter of the new page.)

I also realize now I should probably be targeting language-reference-stable instead of main.

Yes, good point.

@ckipp01 ckipp01 force-pushed the fewerBracesLink branch from 089fcaf to 37a6305 Compare May 19, 2023 08:19
@ckipp01 ckipp01 changed the base branch from main to language-reference-stable May 19, 2023 08:19
@ckipp01 ckipp01 merged commit ee62f32 into scala:language-reference-stable May 19, 2023
@ckipp01 ckipp01 deleted the fewerBracesLink branch May 19, 2023 10:23
G1ng3r pushed a commit to G1ng3r/dotty that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants