Skip to content

add styling to blockquote in content component #17423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented May 5, 2023

fixes #17421

After:
Screenshot 2023-05-05 at 12 51 05

@szymon-rd I was not sure who to assign to, or which branch to use

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 this looks good to me, although I also don't know what the process is for targeting language-reference-stable. I'm assuming for something like this it's fine?

I'm assuming looking at #17419, that this will then automatically send in another PR after to sync?

@bishabosha
Copy link
Member Author

I'm assuming looking at #17419, that this will then automatically send in another PR after to sync?

Yeah the bot will open another PR to sync

@ckipp01
Copy link
Member

ckipp01 commented May 11, 2023

The community build failure was

dotty.communitybuild.CommunityBuildTestC.requests

which is always flaky. I think this is fine, so I'll just go ahead and merge.

@ckipp01 ckipp01 merged commit 28fec6b into scala:language-reference-stable May 11, 2023
@ckipp01 ckipp01 deleted the style-blockquote-docs branch May 11, 2023 09:49
G1ng3r pushed a commit to G1ng3r/dotty that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants