Proxito: fix https and canonical redirects #8193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a https redirect we were adding the default language and version (/en/latest/) if the current url didn't have those components. And similar when doing a redirect to a canonical domain. Fix #8183
stsewd
force-pushed
the
fix-proxito-redirects
branch
from
0b5deb2 to
810abd3
Compare
ericholscher
approved these changes
May 19, 2021
| @@ -0,0 +1,3 @@ | |||
| REDIRECT_HTTPS = 'https' | |||
| REDIRECT_CANONICAL_CNAME = 'canonical-cname' | |||
| REDIRECT_SUBPROJECT_MAIN_DOMAIN = 'subproject-main-domain' | |||
|
This is based on #8187, so I need a review on that one first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a https redirect we were adding the default language and
version (/en/latest/) if the current url didn't have those components.
And similar when doing a redirect to a canonical domain.
Fix #8183
This is based on #8187 since we need to distinguish between redirects to subprojects and canonical redirects.