Search: link to main project in subproject results #7880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stsewd @ericholscher Hey, thanks for taking care of this. Would you have an estimate on when you would be able to merge and deploy this? |
ericholscher
approved these changes
Feb 22, 2021
| @@ -70,6 +70,11 @@ function attach_elastic_search_query_sphinx(data) { | |||
| } | |||
|
|
|||
| var link = result.path + "?highlight=" + $.urlencode(query); | |||
| // If we aren't on the main domain of the subproject, link to it. | |||
| // TODO: we should always redirect to the main domain instead. | |||
| if (result.path.startsWith('/projects/') && !window.location.href.startsWith(result.domain)) { | |||
There was a problem hiding this comment.
I think on .com we allow users to customize this path, so we probably need something smarter here in the future, but this should work for 99% of users for now.
There was a problem hiding this comment.
yeah, I think redirecting to the main project should fix all this, but that's a bigger change in proxito
|
@ramirezfranciscof this should be live by tomorrow afternoon |
|
Thanks a lot, guys! I confirm that this has fixed the issue for us. |
|
Indeed, all works great now, thanks! |
stsewd
added a commit
that referenced
this pull request
May 19, 2021
stsewd
added a commit
that referenced
this pull request
May 25, 2021
Revert #7880 since we now always redirect to the subproject domain.
stsewd
added a commit
that referenced
this pull request
Jun 15, 2021
Revert #7880 since we now always redirect to the subproject domain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm checking for urls stating with
/projects/only, since we don't want to go back to link to the full URL again...Closes #7487