Skip to content

Redirect subprojects to the main domain #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Jan 28, 2021 · 0 comments · Fixed by #8187
Closed

Redirect subprojects to the main domain #7881

stsewd opened this issue Jan 28, 2021 · 0 comments · Fixed by #8187
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Jan 28, 2021

Currently we only redirect from the top domain of the subprojects

https://aiida-core.readthedocs.io -> https://aiida.readthedocs.io/projects/aiida-core/en/latest/

But we don't redirect when serving an specific file:

https://aiida-core.readthedocs.io/en/latest/ doesn't redirect.

This causes problems with search results where we always use relative URLS.

Proxito should check for subprojects and redirect to the main domain.

Ref #7487 (comment)

@stsewd stsewd added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Jan 28, 2021
stsewd added a commit that referenced this issue May 17, 2021
Closes #7881
We can revert #7880
after releasing this.
stsewd added a commit that referenced this issue May 19, 2021
Closes #7881
We can revert #7880
after releasing this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@stsewd and others