Skip to content

Redirect only works with URL prefixed with HTTPS not HTTP #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Daltz333 opened this issue May 14, 2021 · 2 comments · Fixed by #8193
Closed

Redirect only works with URL prefixed with HTTPS not HTTP #8183

Daltz333 opened this issue May 14, 2021 · 2 comments · Fixed by #8193
Labels
Bug A bug

Comments

@Daltz333
Copy link

Daltz333 commented May 14, 2021 •
edited
Loading

Details

  • Read the Docs project URL: https://docs.wpilib.org/
  • Build URL (if applicable): na
  • Read the Docs username (if applicable): na

We have the following redirect setup

image

The redirect works properly if given the URL: https://docs.wpilib.org/stacktrace

It does not work properly if given the same URL but without SSL: http://docs.wpilib.org/stacktrace

I suspect there may be an issue relating to "always use HTTPS for this domain"
@TheTripleV
Copy link

Furthermore, the redirect fails on readthedoc's urls.

Both https://frc-docs.readthedocs.io/stacktrace and http://frc-docs.readthedocs.io/stacktrace fail to follow the specified redirect and instead go to https://docs.wpilib.org/en/stable/stacktrace

@stsewd stsewd added the Bug A bug label May 17, 2021
stsewd added a commit that referenced this issue May 19, 2021
@stsewd
Proxito: fix https and canonical redirects
10f47b9 
When doing a https redirect we were adding the default language and
version (/en/latest/) if the current url didn't have those components.
And similar when doing a redirect to a canonical domain.

Fix #8183
stsewd added a commit that referenced this issue May 19, 2021
@stsewd
Proxito: fix https and canonical redirects
0b5deb2 
When doing a https redirect we were adding the default language and
version (/en/latest/) if the current url didn't have those components.
And similar when doing a redirect to a canonical domain.

Fix #8183
@stsewd stsewd mentioned this issue May 19, 2021
Merged
stsewd added a commit that referenced this issue May 19, 2021
@stsewd
Proxito: fix https and canonical redirects
810abd3 
When doing a https redirect we were adding the default language and
version (/en/latest/) if the current url didn't have those components.
And similar when doing a redirect to a canonical domain.

Fix #8183
stsewd added a commit that referenced this issue May 19, 2021
@stsewd
Proxito: fix https and canonical redirects (#8193)
1ace680 
When doing a https redirect we were adding the default language and
version (/en/latest/) if the current url didn't have those components.
And similar when doing a redirect to a canonical domain.

Fix #8183
@stsewd
Copy link
Member

stsewd commented May 25, 2021

The fix is live, I can see all redirects are good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proxito: fix https and canonical redirects readthedocs/readthedocs.org
3 participants
@stsewd @Daltz333 @TheTripleV