Projects: remove old/non-used fields #11124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow safe migrations instructions from https://dev.readthedocs.io/en/latest/migrations.html to remove these fields.
stsewd
reviewed
Feb 19, 2024
|
We are removing some old project data here as cleanup. Is there any reason why we wouldn't want to do this? cc @stsewd @agjohnson @ericholscher |
Maybe to help migrate people to use a config file, but if we no longer show those values in the UI, don't think there is a strong reason. |
Yeah, we don't show them anymore. We showed them for a few months to help with the migration before removing them from the UI. |
…mitos/remove-old-project-fields
humitos
added a commit
that referenced
this pull request
Feb 21, 2024
This field is not required anymore. It has to be defined in the YAML config file now. This PR continues the work done in #11124
stsewd
approved these changes
Feb 21, 2024
|
I created DB snapshots just in case. I going to merge this PR. |
humitos
added a commit
that referenced
this pull request
Mar 25, 2024
* Projects: remove old/non-used fields Follow safe migrations instructions from https://dev.readthedocs.io/en/latest/migrations.html to remove these fields. * Lint * Keep `Project.documentation_type` to avoid breaking changes * Remove fields from fixture * Remove more leftovers * Lint * Rename migrations * Fix tests * Projects: remove `requirements_file` This field is not required anymore. It has to be defined in the YAML config file now. This PR continues the work done in #11124 * Update migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow safe migrations instructions from
https://dev.readthedocs.io/en/latest/migrations.html to remove these fields.
You can skip 5c556ec from the review since it's the lint for the
projects/models.pyfile --which I'm not sure why it wasn't applied before.