Skip to content

Commit b56cf06

Browse files
committed
Projects: remove requirements_file
This field is not required anymore. It has to be defined in the YAML config file now. This PR continues the work done in #11124
1 parent 778bfda commit b56cf06

File tree

5 files changed

+23
-33
lines changed

5 files changed

+23
-33
lines changed

readthedocs/api/v2/serializers.py

-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ class Meta(ProjectSerializer.Meta):
8484
"container_mem_limit",
8585
"container_time_limit",
8686
"skip",
87-
"requirements_file",
8887
"features",
8988
"has_valid_clone",
9089
"has_valid_webhook",

readthedocs/projects/fixtures/test_data.json

-17
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"single_version": false,
1616
"default_version": "latest",
1717
"default_branch": null,
18-
"requirements_file": null,
1918
"documentation_type": "sphinx",
2019
"external_builds_enabled": false,
2120
"external_builds_privacy_level": "public",
@@ -61,7 +60,6 @@
6160
"single_version": false,
6261
"default_version": "latest",
6362
"default_branch": null,
64-
"requirements_file": null,
6563
"documentation_type": "sphinx",
6664
"external_builds_enabled": false,
6765
"external_builds_privacy_level": "public",
@@ -107,7 +105,6 @@
107105
"single_version": false,
108106
"default_version": "latest",
109107
"default_branch": null,
110-
"requirements_file": null,
111108
"documentation_type": "sphinx",
112109
"external_builds_enabled": false,
113110
"external_builds_privacy_level": "public",
@@ -153,7 +150,6 @@
153150
"single_version": false,
154151
"default_version": "latest",
155152
"default_branch": null,
156-
"requirements_file": null,
157153
"documentation_type": "sphinx",
158154
"external_builds_enabled": false,
159155
"external_builds_privacy_level": "public",
@@ -199,7 +195,6 @@
199195
"single_version": false,
200196
"default_version": "latest",
201197
"default_branch": null,
202-
"requirements_file": null,
203198
"documentation_type": "sphinx",
204199
"external_builds_enabled": false,
205200
"external_builds_privacy_level": "public",
@@ -245,7 +240,6 @@
245240
"single_version": false,
246241
"default_version": "latest",
247242
"default_branch": null,
248-
"requirements_file": null,
249243
"documentation_type": "sphinx",
250244
"external_builds_enabled": false,
251245
"external_builds_privacy_level": "public",
@@ -291,7 +285,6 @@
291285
"single_version": false,
292286
"default_version": "latest",
293287
"default_branch": null,
294-
"requirements_file": null,
295288
"documentation_type": "sphinx",
296289
"external_builds_enabled": false,
297290
"external_builds_privacy_level": "public",
@@ -337,7 +330,6 @@
337330
"single_version": false,
338331
"default_version": "latest",
339332
"default_branch": null,
340-
"requirements_file": null,
341333
"documentation_type": "sphinx",
342334
"external_builds_enabled": false,
343335
"external_builds_privacy_level": "public",
@@ -383,7 +375,6 @@
383375
"single_version": false,
384376
"default_version": "latest",
385377
"default_branch": null,
386-
"requirements_file": null,
387378
"documentation_type": "sphinx",
388379
"external_builds_enabled": false,
389380
"external_builds_privacy_level": "public",
@@ -429,7 +420,6 @@
429420
"single_version": false,
430421
"default_version": "latest",
431422
"default_branch": null,
432-
"requirements_file": null,
433423
"documentation_type": "sphinx",
434424
"external_builds_enabled": false,
435425
"external_builds_privacy_level": "public",
@@ -475,7 +465,6 @@
475465
"single_version": false,
476466
"default_version": "latest",
477467
"default_branch": null,
478-
"requirements_file": null,
479468
"documentation_type": "sphinx",
480469
"external_builds_enabled": false,
481470
"external_builds_privacy_level": "public",
@@ -521,7 +510,6 @@
521510
"single_version": false,
522511
"default_version": "latest",
523512
"default_branch": null,
524-
"requirements_file": null,
525513
"documentation_type": "sphinx",
526514
"external_builds_enabled": false,
527515
"external_builds_privacy_level": "public",
@@ -567,7 +555,6 @@
567555
"single_version": false,
568556
"default_version": "latest",
569557
"default_branch": null,
570-
"requirements_file": null,
571558
"documentation_type": "sphinx",
572559
"external_builds_enabled": false,
573560
"external_builds_privacy_level": "public",
@@ -613,7 +600,6 @@
613600
"single_version": false,
614601
"default_version": "latest",
615602
"default_branch": null,
616-
"requirements_file": null,
617603
"documentation_type": "sphinx",
618604
"external_builds_enabled": false,
619605
"external_builds_privacy_level": "public",
@@ -657,7 +643,6 @@
657643
"single_version": false,
658644
"default_version": "latest",
659645
"default_branch": null,
660-
"requirements_file": null,
661646
"documentation_type": "sphinx",
662647
"external_builds_enabled": false,
663648
"external_builds_privacy_level": "public",
@@ -701,7 +686,6 @@
701686
"single_version": false,
702687
"default_version": "latest",
703688
"default_branch": null,
704-
"requirements_file": null,
705689
"documentation_type": "sphinx",
706690
"external_builds_enabled": false,
707691
"external_builds_privacy_level": "public",
@@ -745,7 +729,6 @@
745729
"single_version": false,
746730
"default_version": "latest",
747731
"default_branch": null,
748-
"requirements_file": null,
749732
"documentation_type": "sphinx",
750733
"external_builds_enabled": false,
751734
"external_builds_privacy_level": "public",
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# Generated by Django 4.2.10 on 2024-02-21 11:36
2+
3+
from django.db import migrations
4+
from django_safemigrate import Safe
5+
6+
7+
class Migration(migrations.Migration):
8+
safe = Safe.after_deploy
9+
10+
dependencies = [
11+
("projects", "0117_remove_old_fields"),
12+
]
13+
14+
operations = [
15+
migrations.RemoveField(
16+
model_name="historicalproject",
17+
name="requirements_file",
18+
),
19+
migrations.RemoveField(
20+
model_name="project",
21+
name="requirements_file",
22+
),
23+
]

readthedocs/projects/models.py

-14
Original file line numberDiff line numberDiff line change
@@ -302,20 +302,6 @@ class Project(models.Model):
302302
"to use the default value for your VCS.",
303303
),
304304
)
305-
requirements_file = models.CharField(
306-
_("Requirements file"),
307-
max_length=255,
308-
default=None,
309-
null=True,
310-
blank=True,
311-
help_text=_(
312-
"A <a "
313-
'href="https://pip.pypa.io/en/latest/user_guide.html#requirements-files">'
314-
"pip requirements file</a> needed to build your documentation. "
315-
"Path from the root of your project.",
316-
),
317-
)
318-
319305
custom_prefix = models.CharField(
320306
_("Custom path prefix"),
321307
max_length=255,

readthedocs/rtd_tests/tests/test_api.py

-1
Original file line numberDiff line numberDiff line change
@@ -3244,7 +3244,6 @@ def test_get_version_by_id(self):
32443244
"programming_language": "words",
32453245
"repo": "https://github.com/pypa/pip",
32463246
"repo_type": "git",
3247-
"requirements_file": None,
32483247
"readthedocs_yaml_path": None,
32493248
"show_advertising": True,
32503249
"skip": False,

0 commit comments

Comments
 (0)