Skip to content

Commit 98e33f4

Browse files
humitoshumitos
authored
Projects: remove old/non-used fields (#11124)
* Projects: remove old/non-used fields Follow safe migrations instructions from https://dev.readthedocs.io/en/latest/migrations.html to remove these fields. * Lint * Keep `Project.documentation_type` to avoid breaking changes * Remove fields from fixture * Remove more leftovers * Lint * Rename migrations * Fix tests
1 parent 48203f2 commit 98e33f4

13 files changed

+1032
-1030
lines changed

‎readthedocs/api/v2/serializers.py

-5
Original file line numberDiff line numberDiff line change
@@ -77,19 +77,14 @@ def get_skip(self, obj):
7777

7878
class Meta(ProjectSerializer.Meta):
7979
fields = ProjectSerializer.Meta.fields + (
80-
"enable_epub_build",
81-
"enable_pdf_build",
82-
"conf_py_file",
8380
"analytics_code",
8481
"analytics_disabled",
8582
"cdn_enabled",
8683
"container_image",
8784
"container_mem_limit",
8885
"container_time_limit",
89-
"install_project",
9086
"skip",
9187
"requirements_file",
92-
"python_interpreter",
9388
"features",
9489
"has_valid_clone",
9590
"has_valid_webhook",

‎readthedocs/doc_builder/config.py

-10
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,3 @@ def load_yaml_config(version, readthedocs_yaml_path=None):
2828
readthedocs_yaml_path=readthedocs_yaml_path,
2929
)
3030
return config
31-
32-
33-
def get_default_formats(project):
34-
"""Get a list of the default formats for ``project``."""
35-
formats = ["htmlzip"]
36-
if project.enable_epub_build:
37-
formats += ["epub"]
38-
if project.enable_pdf_build:
39-
formats += ["pdf"]
40-
return formats

‎readthedocs/projects/fixtures/test_data.json

-102
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,8 @@
3131
"ad_free": false,
3232
"is_spam": null,
3333
"show_version_warning": false,
34-
"enable_epub_build": true,
35-
"enable_pdf_build": true,
36-
"path": "",
37-
"conf_py_file": "",
3834
"featured": false,
3935
"skip": false,
40-
"install_project": false,
41-
"python_interpreter": "python3",
4236
"privacy_level": "public",
4337
"language": "en",
4438
"programming_language": "words",
@@ -83,14 +77,8 @@
8377
"ad_free": false,
8478
"is_spam": null,
8579
"show_version_warning": false,
86-
"enable_epub_build": true,
87-
"enable_pdf_build": true,
88-
"path": "",
89-
"conf_py_file": "",
9080
"featured": false,
9181
"skip": false,
92-
"install_project": false,
93-
"python_interpreter": "python3",
9482
"privacy_level": "public",
9583
"language": "en",
9684
"programming_language": "words",
@@ -135,14 +123,8 @@
135123
"ad_free": false,
136124
"is_spam": null,
137125
"show_version_warning": false,
138-
"enable_epub_build": true,
139-
"enable_pdf_build": true,
140-
"path": "",
141-
"conf_py_file": "",
142126
"featured": false,
143127
"skip": false,
144-
"install_project": false,
145-
"python_interpreter": "python3",
146128
"privacy_level": "public",
147129
"language": "en",
148130
"programming_language": "words",
@@ -187,14 +169,8 @@
187169
"ad_free": false,
188170
"is_spam": null,
189171
"show_version_warning": false,
190-
"enable_epub_build": true,
191-
"enable_pdf_build": true,
192-
"path": "",
193-
"conf_py_file": "",
194172
"featured": false,
195173
"skip": false,
196-
"install_project": false,
197-
"python_interpreter": "python3",
198174
"privacy_level": "public",
199175
"language": "en",
200176
"programming_language": "words",
@@ -239,14 +215,8 @@
239215
"ad_free": false,
240216
"is_spam": null,
241217
"show_version_warning": false,
242-
"enable_epub_build": true,
243-
"enable_pdf_build": true,
244-
"path": "",
245-
"conf_py_file": "",
246218
"featured": false,
247219
"skip": false,
248-
"install_project": false,
249-
"python_interpreter": "python3",
250220
"privacy_level": "public",
251221
"language": "en",
252222
"programming_language": "words",
@@ -291,14 +261,8 @@
291261
"ad_free": false,
292262
"is_spam": null,
293263
"show_version_warning": false,
294-
"enable_epub_build": true,
295-
"enable_pdf_build": true,
296-
"path": "",
297-
"conf_py_file": "",
298264
"featured": false,
299265
"skip": false,
300-
"install_project": false,
301-
"python_interpreter": "python3",
302266
"privacy_level": "public",
303267
"language": "en",
304268
"programming_language": "words",
@@ -343,14 +307,8 @@
343307
"ad_free": false,
344308
"is_spam": null,
345309
"show_version_warning": false,
346-
"enable_epub_build": true,
347-
"enable_pdf_build": true,
348-
"path": "",
349-
"conf_py_file": "",
350310
"featured": false,
351311
"skip": false,
352-
"install_project": false,
353-
"python_interpreter": "python3",
354312
"privacy_level": "public",
355313
"language": "en",
356314
"programming_language": "words",
@@ -395,14 +353,8 @@
395353
"ad_free": false,
396354
"is_spam": null,
397355
"show_version_warning": false,
398-
"enable_epub_build": true,
399-
"enable_pdf_build": true,
400-
"path": "",
401-
"conf_py_file": "",
402356
"featured": false,
403357
"skip": false,
404-
"install_project": false,
405-
"python_interpreter": "python3",
406358
"privacy_level": "public",
407359
"language": "en",
408360
"programming_language": "words",
@@ -447,14 +399,8 @@
447399
"ad_free": false,
448400
"is_spam": null,
449401
"show_version_warning": false,
450-
"enable_epub_build": true,
451-
"enable_pdf_build": true,
452-
"path": "",
453-
"conf_py_file": "",
454402
"featured": false,
455403
"skip": false,
456-
"install_project": false,
457-
"python_interpreter": "python3",
458404
"privacy_level": "public",
459405
"language": "en",
460406
"programming_language": "words",
@@ -499,14 +445,8 @@
499445
"ad_free": false,
500446
"is_spam": null,
501447
"show_version_warning": false,
502-
"enable_epub_build": true,
503-
"enable_pdf_build": true,
504-
"path": "",
505-
"conf_py_file": "",
506448
"featured": false,
507449
"skip": false,
508-
"install_project": false,
509-
"python_interpreter": "python3",
510450
"privacy_level": "public",
511451
"language": "en",
512452
"programming_language": "words",
@@ -551,14 +491,8 @@
551491
"ad_free": false,
552492
"is_spam": null,
553493
"show_version_warning": false,
554-
"enable_epub_build": true,
555-
"enable_pdf_build": true,
556-
"path": "",
557-
"conf_py_file": "",
558494
"featured": false,
559495
"skip": false,
560-
"install_project": false,
561-
"python_interpreter": "python3",
562496
"privacy_level": "public",
563497
"language": "en",
564498
"programming_language": "words",
@@ -603,14 +537,8 @@
603537
"ad_free": false,
604538
"is_spam": null,
605539
"show_version_warning": false,
606-
"enable_epub_build": true,
607-
"enable_pdf_build": true,
608-
"path": "",
609-
"conf_py_file": "",
610540
"featured": false,
611541
"skip": false,
612-
"install_project": false,
613-
"python_interpreter": "python3",
614542
"privacy_level": "public",
615543
"language": "en",
616544
"programming_language": "words",
@@ -655,14 +583,8 @@
655583
"ad_free": false,
656584
"is_spam": null,
657585
"show_version_warning": false,
658-
"enable_epub_build": true,
659-
"enable_pdf_build": true,
660-
"path": "",
661-
"conf_py_file": "",
662586
"featured": false,
663587
"skip": false,
664-
"install_project": false,
665-
"python_interpreter": "python3",
666588
"privacy_level": "public",
667589
"language": "en",
668590
"programming_language": "words",
@@ -707,14 +629,8 @@
707629
"ad_free": false,
708630
"is_spam": null,
709631
"show_version_warning": false,
710-
"enable_epub_build": true,
711-
"enable_pdf_build": true,
712-
"path": "",
713-
"conf_py_file": "",
714632
"featured": false,
715633
"skip": false,
716-
"install_project": false,
717-
"python_interpreter": "python3",
718634
"privacy_level": "public",
719635
"language": "en",
720636
"programming_language": "words",
@@ -757,14 +673,8 @@
757673
"ad_free": false,
758674
"is_spam": null,
759675
"show_version_warning": false,
760-
"enable_epub_build": true,
761-
"enable_pdf_build": true,
762-
"path": "",
763-
"conf_py_file": "",
764676
"featured": false,
765677
"skip": false,
766-
"install_project": false,
767-
"python_interpreter": "python3",
768678
"privacy_level": "public",
769679
"language": "en",
770680
"programming_language": "words",
@@ -807,14 +717,8 @@
807717
"ad_free": false,
808718
"is_spam": null,
809719
"show_version_warning": false,
810-
"enable_epub_build": true,
811-
"enable_pdf_build": true,
812-
"path": "",
813-
"conf_py_file": "",
814720
"featured": false,
815721
"skip": false,
816-
"install_project": false,
817-
"python_interpreter": "python3",
818722
"privacy_level": "public",
819723
"language": "en",
820724
"programming_language": "words",
@@ -857,14 +761,8 @@
857761
"ad_free": false,
858762
"is_spam": null,
859763
"show_version_warning": false,
860-
"enable_epub_build": true,
861-
"enable_pdf_build": true,
862-
"path": "",
863-
"conf_py_file": "",
864764
"featured": false,
865765
"skip": false,
866-
"install_project": false,
867-
"python_interpreter": "python3",
868766
"privacy_level": "public",
869767
"language": "en",
870768
"programming_language": "words",

0 commit comments

Comments
 (0)