Skip to content

Deprecation: Disabled version of "Default settings" or other guidance? #10386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjaoming opened this issue Jun 5, 2023 · 1 comment
Closed
Labels
Needed: design decision A core team decision is required

Comments

@benjaoming
Copy link
Contributor

Refs: #10342

I noticed in this draft PR that we are removing the "Default settings" fieldset entirely from Advanced Settings: #10367

If we do that, then users won't be able to tell what their previous configuration was. Since we still keep the database fields, we have two alternative options:

  1. Disable these input fields so the values are still visible
  2. Output their values in a table, given that the project still hasn't migrated to .readthedocs.yaml

The "use case" for this would be projects that haven't acted on the deprecation, presumably because they weren't building anything in the deprecation period and didn't find it necessary to migrate yet.

image

@humitos
Copy link
Member

humitos commented Feb 21, 2024

We kept showing these values as read-only for a few months after the deprecation. Now, we have deleted them from the form and we are deleting them from the db as well in #11124. There is nothing else to do here now.

@humitos humitos closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants