-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Notification: beta swap template logic fixes #11209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm still waiting on this one as we are just getting to testing auth. When we are closer to giving users the new auth pages I'll have more interest in doing this for both sites. |
We have auth pages already working on new It would be good if we can move forward with this, so we can migrate more users to the new templates soon 🎉 . We are pretty close 😄 |
- Fix user new dashboard notification, support both legacy and new dashbaord - Update other pointers in the UI to the new dashboard - Drop the beta build notification ---- - Refs #11209
- Fix user new dashboard notification, support both legacy and new dashbaord - Update other pointers in the UI to the new dashboard - Drop the beta build notification ---- - Refs #11209
- Add new dashboard announcement template - Fix issues around spacing of top notifications - Drop unused block on build detail page 1cfe710 is a linting step ---- - Refs readthedocs/readthedocs.org#11543 - Refs readthedocs/readthedocs.org#11209 - Refs readthedocs/website#335 ---- - [x] Update blog url
Notification on new dashboard:  Notification on old dashboard:  ---- - Fixes #11209 - Requires readthedocs/ext-theme#524 - Refs readthedocs/website#335
While working on #11208 I found issues likely affecting the beta notification message. Just noting for now:
{{ PRODUCTION_DOMAIN }}
isbeta.readthedocs.org
, notreadthedocs.org
. The link should use PRODUCTION_DOMAIN|slice:"5:" or similarbeta.readthedocs.com/projects/foo
, as this will always 404 if the user is not logged in. Instead Add build detail view beta notification #11208 links to the login view first, to ensure the user is always seeing the login first if they are not logged in yet.This notification is getting into some complex area already, it might be also worth implementing the last part that #11208 added, which was linking to the same url between both dashboards.
The text was updated successfully, but these errors were encountered: