Skip to content

Fix site-wide new dashboard notification #11543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Aug 15, 2024

@agjohnson agjohnson force-pushed the agj/global-notification-fixes branch 2 times, most recently from 5aac970 to b7c3379 Compare November 9, 2024 03:43
- Fix user new dashboard notification, support both legacy and new dashbaord
- Update other pointers in the UI to the new dashboard
- Drop the beta build notification

----

- Refs #11209
@agjohnson
Copy link
Contributor Author

Test failure should be fixed after readthedocs/ext-theme#524

@agjohnson agjohnson marked this pull request as ready for review November 12, 2024 07:51
@agjohnson agjohnson requested a review from a team as a code owner November 12, 2024 07:51
@agjohnson agjohnson requested a review from stsewd November 12, 2024 07:51
@agjohnson agjohnson requested a review from humitos November 12, 2024 08:05
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

humitos pushed a commit to readthedocs/ext-theme that referenced this pull request Nov 12, 2024
- Add new dashboard announcement template
- Fix issues around spacing of top notifications
- Drop unused block on build detail page

1cfe710 is a linting step

----

- Refs readthedocs/readthedocs.org#11543
- Refs readthedocs/readthedocs.org#11209
- Refs readthedocs/website#335

----

- [x] Update blog url
@humitos humitos merged commit 7bceb65 into main Nov 12, 2024
7 of 8 checks passed
@humitos humitos deleted the agj/global-notification-fixes branch November 12, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification: beta swap template logic fixes
2 participants