Skip to content

Add build detail view beta notification #11208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Add build detail view beta notification #11208

merged 3 commits into from
Mar 12, 2024

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Mar 12, 2024

This adds a notification to the corresponding beta build detail view,
and works for both community and commercial. There are two separate
patterns here as a link to the beta dashboard will 404 if the user is not logged in there yet. That is, linking to beta.readthedocs.com/projects/foo/ will 404 instead of ask the user to sign in first.

The two URLs generated for me are:

image
image

This adds a notification to the corresponding beta build detail view,
and works for both community and commercial. There are two separate
patterns here as the authentication is a little bit different between
the two sites.
@agjohnson agjohnson requested review from a team as code owners March 12, 2024 00:50
@agjohnson agjohnson requested a review from humitos March 12, 2024 00:50
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohooo! The new dashboard it a lot better 🥳

@humitos humitos merged commit ed1f564 into main Mar 12, 2024
@humitos humitos deleted the agj/build-beta-notice branch March 12, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants