Skip to content

Notifications: add a test for notifications on build detail's page #11157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Feb 27, 2024 · 5 comments
Closed

Notifications: add a test for notifications on build detail's page #11157

humitos opened this issue Feb 27, 2024 · 5 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: tests Tests are required

Comments

@humitos
Copy link
Member

humitos commented Feb 27, 2024

We should add a test for #11153.

I just merged it because I want to deploy it today since it's a bug that's affecting too many users.

@humitos humitos added Improvement Minor improvement to code Needed: tests Tests are required Accepted Accepted issue on our roadmap labels Feb 27, 2024
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Feb 27, 2024
@humitos humitos self-assigned this Feb 28, 2024
@agjohnson
Copy link
Contributor

It might be best to write these tests against the API, as the new dashboard will be loading these from there, not from templates.

@humitos
Copy link
Member Author

humitos commented Mar 4, 2024

IIRC, the API already have tests for this. The idea of this issue was to avoid re-introducing the bug that #11153 fixes. I'm fine skipping this issue, tho --since we won't be using the old dashboard in the future. Maybe this is a no-op issue at this point.

@ericholscher ericholscher moved this from Planned to In progress in 📍Roadmap Mar 12, 2024
@ericholscher
Copy link
Member

Is this done with #11208 ?

@ericholscher ericholscher moved this from In progress to Planned in 📍Roadmap Mar 12, 2024
@humitos
Copy link
Member Author

humitos commented Mar 12, 2024

No. This is about adding a test case to avoid repeating the issue #11153 -- but it's kind of invalid at the moment since we re-implementing this work in the new dashboard via APIv3

@github-project-automation github-project-automation bot moved this from Planned to Done in 📍Roadmap Mar 27, 2024
@ericholscher
Copy link
Member

This is for the old dashboard, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: tests Tests are required
Projects
Archived in project
Development

No branches or pull requests

3 participants