Drop "Unknown message" notification #11542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
reviewed
Aug 16, 2024
agjohnson
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Aug 16, 2024
If the message was not found on a notification, don't try to display anything. - Refs readthedocs/readthedocs.org#11542
|
Ah yes, I forgot I did have some code stashed to guard against a null A better design might have been for the notification to not return from the API at all, however this seems hard/maybe expensive with messages being a string lookup instead of database objects. However, this use case is minor and unlikely already. I don't think we need to be exact here on the implementation. |
This comment was marked as spam.
This comment was marked as spam.
Yeah, this would be ideal 👍🏼 |
humitos
approved these changes
Aug 19, 2024
agjohnson
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Aug 19, 2024
If the message was not found on a notification, don't try to display anything. - Refs readthedocs/readthedocs.org#11542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this fix sitting around, I hit this while trying to work on #11209