-
-
Notifications
You must be signed in to change notification settings - Fork 22
Support for non-serializable component parameters #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for non-serializable component parameters #120
Conversation
@rmorshea This is fully functional but currently has no eviction/expiration strategy implemented. Let me know what you think. |
Will take a look tomorrow |
Overall LGTM. Perhaps we could add a test which passes a parameter to a component that isn't JSON serializable? |
The reconnect variable has been changed to better describe the new behavior. Also, the rename helps in preparation for reactive-python/reactpy#525 In the future, I hope to introduce a |
Changelog in the PR's description has been updated. |
I've added tests for the component parameter cleanup logic |
@rmorshea This has security fixes, so I'd like to get this out soon if possible. |
I removed the version bump from this PR. I will create a follow-up PR that bumps IDOM to |
Will review tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally approve, just few minor nits/comments
Let me know if we're okay with the approach on the 3 unresolved comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything looks good to me.
Description
Functional implementation of database-backed component params
Changelog
component
template tag now supports both positional and keyword arguments.component
template tag now supports non-serializable arguments.manage.py migrate
after installing IDOMIDOM_WS_MAX_RECONNECT_TIMEOUT
has been renamed toIDOM_RECONNECT_MAX
and is now used as the default timeout for component parametersidom.backend.hooks
support.django_idom.types.IdomWebsocket
has been renamed toConnection
and modified to fit the new schemaview_to_component
utility will now automatically usedel_html_head_body_transform
IDOM_DEBUG_MODE
tosettings.py:DEBUG
django_query_postprocessor
Checklist:
Please update this checklist as you complete each item: