Skip to content

Improve Reconnecting WS Configurability #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Archmonger opened this issue Nov 1, 2021 · 0 comments · Fixed by #1113
Closed

Improve Reconnecting WS Configurability #525

Archmonger opened this issue Nov 1, 2021 · 0 comments · Fixed by #1113
Labels
priority-2-moderate Should be resolved on a reasonable timeline.

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Nov 1, 2021

Current Situation

Currently the configuration for reconnecting WS is fairly limited.

Proposed Changes

We can potentially add settings for MAX_TIMEOUT , MAX_RETRIES, and/or RECONNECT_INTERVAL.

Alternatively, allow the user to define his own JavaScript WS reconnection function.

Implementation Details

From @rmorshea
I'd actually like to modify how reconnections happen so its more configurable. It should accept a callback that receives the last delay, and the total elapsed time as its arguments and returns the next delay.

It should probably be even a bit more general in that, there should be a way to hook into the full lifecycle of the connection:

  • before initial connection
  • connected
  • disconnected
  • closed
  • etc...
@Archmonger Archmonger added the flag-triage Not prioritized. label Nov 1, 2021
@rmorshea rmorshea added enhancement and removed flag-triage Not prioritized. labels Jan 9, 2022
@rmorshea rmorshea added this to the 2.0 milestone Jan 11, 2022
@rmorshea rmorshea added the priority-2-moderate Should be resolved on a reasonable timeline. label Jan 13, 2022
@Archmonger Archmonger modified the milestones: Luxury, Essential Jan 29, 2023
@rmorshea rmorshea removed this from the Essential milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2-moderate Should be resolved on a reasonable timeline.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants