Skip to content

Support for non-serializable component parameters #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Feb 2, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
48ef41d
fix use_location bug
Archmonger Jan 9, 2023
89a59d6
add missing migration
Archmonger Jan 10, 2023
2247a18
enable django mypy plugin
Archmonger Jan 10, 2023
f2b5a3a
Functional DB-backed component params
Archmonger Jan 10, 2023
0b11cf7
remove broken django stubs
Archmonger Jan 10, 2023
587cfa3
fix type hints
Archmonger Jan 10, 2023
e93253c
skip migrations
Archmonger Jan 10, 2023
8a84f1d
bump idom version
Archmonger Jan 10, 2023
3760dde
Use idom 0.43.0 hooks
Archmonger Jan 10, 2023
e686894
don't render component if args/kwargs are wrong
Archmonger Jan 10, 2023
4b7676c
docs and changelog
Archmonger Jan 10, 2023
0f57702
Add object in templatetag tests
Archmonger Jan 10, 2023
9432349
fix styling errors
Archmonger Jan 10, 2023
a87a7b5
type hints for user
Archmonger Jan 10, 2023
4f41975
validate function signature
Archmonger Jan 10, 2023
ec46469
use lowercase tuple
Archmonger Jan 11, 2023
5e75488
functioning eviction strategy
Archmonger Jan 11, 2023
7344a97
don't clean DB on startup if running django tests
Archmonger Jan 11, 2023
d2d4573
switch sys check to contextlib suppress
Archmonger Jan 11, 2023
ace4a34
view_to_component uses del_html_head_body_transform
Archmonger Jan 11, 2023
8cf2884
update docs
Archmonger Jan 11, 2023
d985e14
add serializable to dictionary
Archmonger Jan 11, 2023
3011e75
fix #35
Archmonger Jan 11, 2023
e9a1364
fix #29
Archmonger Jan 11, 2023
e0fcbd9
Make some utils public if they're harmless
Archmonger Jan 12, 2023
2adb676
Make DATE_FORMAT a global
Archmonger Jan 12, 2023
319dda2
validate params_query expiration within fetch queries
Archmonger Jan 12, 2023
00e3c85
refactor db_cleanup
Archmonger Jan 12, 2023
43f4a32
more deprivatization
Archmonger Jan 12, 2023
f79f936
document django_query_postprocessor
Archmonger Jan 12, 2023
83730cd
comment for _register_component
Archmonger Jan 12, 2023
5dd8d16
add postprocessor to dictionary
Archmonger Jan 12, 2023
9f6b757
docs revision
Archmonger Jan 14, 2023
5d56d23
misc docs updates
Archmonger Jan 14, 2023
827adf3
move hooks back into `django_idom.hooks`
Archmonger Jan 14, 2023
6a08531
Merge remote-tracking branch 'upstream/main' into database-backed-kwargs
Archmonger Jan 14, 2023
03f315b
v3.0.0
Archmonger Jan 14, 2023
8f83c1b
docs formatting
Archmonger Jan 14, 2023
be07851
better link for keys
Archmonger Jan 15, 2023
6209c07
subclass core's Connection
Archmonger Jan 15, 2023
04a2efc
Complete types list
Archmonger Jan 15, 2023
196c756
remove unused ignore
Archmonger Jan 15, 2023
ac415dd
tests for ComponentParams expiration
Archmonger Jan 16, 2023
6447885
use tuple for ComponentParamData
Archmonger Jan 16, 2023
1a9b06e
better type hints for ComponentParamData
Archmonger Jan 16, 2023
cb0bd4f
Better type hints for postprocessor_kwargs
Archmonger Jan 16, 2023
648d3a2
type hint fixes
Archmonger Jan 16, 2023
54b9840
type hint for ComponentPreloader
Archmonger Jan 16, 2023
976f10f
timezone might not always be available, so don't rely on it.
Archmonger Jan 20, 2023
3f6069c
more robust ComponentParams tests
Archmonger Jan 22, 2023
abc3439
always lazy load config
Archmonger Jan 22, 2023
d7809f9
remove defaults.py
Archmonger Jan 22, 2023
a2a2c8c
remove version bump
Archmonger Jan 28, 2023
468d52f
fix type hint issues
Archmonger Jan 28, 2023
0d9d4a9
change mypy to incremental
Archmonger Feb 1, 2023
a0194c0
format using new black version
Archmonger Feb 1, 2023
f5cc229
log when idom database is not ready at startup
Archmonger Feb 2, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ ensure_newline_before_comments = "True"
include_trailing_comma = "True"
line_length = 88
lines_after_imports = 2
skip = ['src/django_idom/migrations/', 'tests/test_app/migrations/', '.nox/', '.venv/', 'build/']

[tool.mypy]
exclude = [
Expand Down
4 changes: 2 additions & 2 deletions src/django_idom/websocket/consumer.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Anything used to construct a websocket endpoint"""
import asyncio
import logging
from typing import Any
from typing import Any, Tuple

import dill as pickle
from channels.auth import login
Expand Down Expand Up @@ -64,7 +64,7 @@ async def _run_dispatch_loop(self):
),
carrier=WebsocketConnection(self.close, self.disconnect, dotted_path),
)
component_args: tuple[Any, ...] = tuple()
component_args: Tuple[Any, ...] = tuple()
component_kwargs: dict = {}

try:
Expand Down