Skip to content

Set React Client to PRODUCTION by default #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
Archmonger opened this issue Jan 9, 2022 · 0 comments · Fixed by #120
Closed
1 task done

Set React Client to PRODUCTION by default #35

Archmonger opened this issue Jan 9, 2022 · 0 comments · Fixed by #120
Labels
priority: 3 (low) type: revision

Comments

@Archmonger
Copy link
Contributor

Old Behavior

Currently, the react client is set to development by default.

New Behavior

Build the react client in production mode by default, or intelligently select a client based on IDOM_DEBUG_MODE

Implementation Details

Change the const { PRODUCTION } = process.env; to default to True

Consider a method where this can be done at run-time.

See related issue reactive-python/reactpy#346

Code of Conduct
@Archmonger Archmonger added triage and removed triage labels Jan 9, 2022
Archmonger added a commit to Archmonger/reactpy-django that referenced this issue Jan 11, 2023
@Archmonger
fix reactive-python#35
3011e75
@Archmonger Archmonger linked a pull request Jan 11, 2023 that will close this issue
Support for non-serializable component parameters #120
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: 3 (low) type: revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for non-serializable component parameters Archmonger/reactpy-django
1 participant
@Archmonger