WEB: Sort PDEPs by their number #52072
Conversation
There was a problem hiding this comment.
Thanks @kostyafarber. The approach seems fine, I think it's the best. I added a couple of minor comments about the implenentation.
|
@datapythonista thx for review. New commit has the suggested changes. |
@datapythonista being a pest :) |
There was a problem hiding this comment.
Thanks @kostyafarber, very nice. Looks great, my only concern is that if one of the sorted issues doesn't use PDEP-\d... as the title, I think this will fail with an error difficult to debug. I'm in my phone and can't check in detail, but let me know if I'm wrong. If I'm correct, maybe we can move the lambda to a function (can be inside the same function) and raise our own exception and error message when the pattern is not found. Thanks!
No worries, I think that's a sensible concern, I'll investigate and let you know. |
|
@datapythonista re-wrote to raise when we don't get a match with (useful) msg. Cheers |
|
@datapythonista friendly ping. |
There was a problem hiding this comment.
Thank you @kostyafarber, I added couple of final suggestions, but looks good.
There was a problem hiding this comment.
Thanks @kostyafarber, looks perfect. I'll leave this open a bit to see if another core dev can have a look, bit will be merge soon if nobody does.
|
/preview |
|
Website preview of this PR available at: https://pandas.pydata.org/preview/52072/ |
|
Thanks @kostyafarber |
* WEB: Sort PDEPs by their number * change regex string and call match method on compiled pattern * WEB: add exception handling when title is missing number * WEB: parameter to sort_pdep should be a dict. Change func parameter type to dict * move pattern into function call, less verbose
* WEB: Sort PDEPs by their number * change regex string and call match method on compiled pattern * WEB: add exception handling when title is missing number * WEB: parameter to sort_pdep should be a dict. Change func parameter type to dict * move pattern into function call, less verbose
Sort PDEPs by their number rather than the title.