Skip to content

WEB: Sorting of PDEPs #51662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datapythonista opened this issue Feb 27, 2023 · 3 comments · Fixed by #52072
Closed

WEB: Sorting of PDEPs #51662

datapythonista opened this issue Feb 27, 2023 · 3 comments · Fixed by #52072
Labels
Needs Discussion Requires discussion from core team before further action Web pandas website

Comments

@datapythonista
Copy link
Member

xref #51656 (comment)

The list of PDEPs is growing, and we're likely to have a PDEP-10 soon. So far, we list PDEPs at https://pandas.pydata.org/about/roadmap.html, and we started sorting the PDEP list by title in #51656. As the numbers grow to 10, sorting naively by title will make that PDEP-2 > PDEP-10. To keep the list sorted, we have two main options, use a regex to extract the number, convert it to int, and sort by it, or use PDEP-001... in PDEP PR titles so the current sorting comes naturally. Personally I don't have a preference, I guess we can make the sort a bit more complex and make our life easier. But since there is some work on PDEPs, some discussion on moving to another repo... I prefer to ask, in case there are other ideas.

@datapythonista datapythonista added Web pandas website Needs Discussion Requires discussion from core team before further action labels Feb 27, 2023
@kostyafarber
Copy link
Contributor

Hey, I know this still needs discussion but I've put something together that extracts the number from the titles using regex and sorts on that.

I can open a PR for it, and we can discuss if we want to go down this route, if not we can always close it.

My two cents, I think it looks cleaner if we use numbers like 1 as opposed to 001 etc. It also aligns to how PEPs are numbered for Python (https://peps.python.org/pep-0000/), which is nice I guess.

Let me know @datapythonista

@datapythonista
Copy link
Member Author

I'm open to any approach, if you can open the PR that'd be great. Please ping me when you do, so I can have a look.

@kostyafarber
Copy link
Contributor

@datapythonista cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion Requires discussion from core team before further action Web pandas website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants