Skip to content

WEB: Sort PDEPs by their number #52072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 22, 2023
Merged

WEB: Sort PDEPs by their number #52072

Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
91c1ff3
WEB: Sort PDEPs by their number
kostyafarber Mar 19, 2023
d621376
Merge branch 'main' into sort-pdeps
kostyafarber Mar 19, 2023
a862ffc
change regex string and call match method on compiled pattern
kostyafarber Mar 21, 2023
95eb7c6
Merge branch 'main' into sort-pdeps
kostyafarber Mar 21, 2023
b6912d0
Merge branch 'main' into sort-pdeps
kostyafarber Mar 23, 2023
887523c
WEB: add exception handling when title is missing number
kostyafarber Apr 29, 2023
048c757
Merge branch 'main' into sort-pdeps
kostyafarber Apr 29, 2023
38bbf29
WEB: parameter to sort_pdep should be a dict. Change func parameter t…
kostyafarber Apr 29, 2023
11b5322
Merge branch 'main' into sort-pdeps
kostyafarber May 7, 2023
6015df3
move pattern into function call, less verbose
kostyafarber May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion web/pandas_web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,20 @@ def roadmap_pdeps(context):
) as f:
json.dump(pdeps, f)

for pdep in sorted(pdeps["items"], key=operator.itemgetter("title")):
regex = r"^PDEP-(\d+)"
compiled_pattern = re.compile(regex)

def sort_pdep(pdep: dict) -> int:
title = pdep["title"]
match = compiled_pattern.match(title)
if not match:
msg = f"""Could not find PDEP number in '{title}'. Please make sure to
write the title as: 'PDEP-num: {title}'."""
raise ValueError(msg)

return int(match[1])

for pdep in sorted(pdeps["items"], key=sort_pdep):
context["pdeps"]["Under discussion"].append(
{"title": pdep["title"], "url": pdep["html_url"]}
)
Expand Down