WEB: Sort PDEPs by their number (#52072)

* WEB: Sort PDEPs by their number

* change regex string and call match method on compiled pattern

* WEB: add exception handling when title is missing number

* WEB: parameter to sort_pdep should be a dict. Change func parameter type to dict

* move pattern into function call, less verbose

Author: kostyafarber

web/pandas_web.py

@@ -317,7 +317,19 @@ def roadmap_pdeps(context):
         ) as f:
             json.dump(pdeps, f)
 
-        for pdep in sorted(pdeps["items"], key=operator.itemgetter("title")):
+        compiled_pattern = re.compile(r"^PDEP-(\d+)")
+
+        def sort_pdep(pdep: dict) -> int:
+            title = pdep["title"]
+            match = compiled_pattern.match(title)
+            if not match:
+                msg = f"""Could not find PDEP number in '{title}'. Please make sure to
+                write the title as: 'PDEP-num: {title}'."""
+                raise ValueError(msg)
+
+            return int(match[1])
+
+        for pdep in sorted(pdeps["items"], key=sort_pdep):
             context["pdeps"]["Under discussion"].append(
                 {"title": pdep["title"], "url": pdep["html_url"]}
             )