REF: remove always-UTC arg from tz_convert, tz_convert_single #35154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* REF: dont consolidate in BlockManager.equals * doctest fixup * Remove Block.equals * simplify, comments
mroeschke
reviewed
Jul 7, 2020
pandas/_libs/tslibs/tzconversion.pyx
Outdated
|
|
||
|
|
||
| def tz_convert(int64_t[:] vals, tzinfo tz1, tzinfo tz2): | ||
| def tz_convert(int64_t[:] vals, tzinfo tz): |
There was a problem hiding this comment.
Could we rename this tz_convert_from_utc to make the intention clear?
pandas/_libs/tslibs/tzconversion.pyx
Outdated
| """ | ||
| Convert the val (in i8) from timezone1 to timezone2 | ||
| Convert the val (in i8) from UTC to tz | ||
|
|
||
| This is a single timezone version of tz_convert |
jreback
reviewed
Jul 8, 2020
pandas/_libs/tslibs/tzconversion.pyx
Outdated
| return np.array(converted, dtype=np.int64) | ||
|
|
||
|
|
||
| @cython.boundscheck(False) | ||
| @cython.wraparound(False) | ||
| cdef int64_t[:] _tz_convert_one_way(int64_t[:] vals, tzinfo tz, bint to_utc): | ||
| cdef int64_t[:] _tz_convert_one_way(int64_t[:] vals, tzinfo tz): |
|
thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.